Repository navigation
Conversation
yuecideng
added this pull request to stack #816
October 18, 2026 12:08
5 tasks done
This was referenced Oct 18, 2026
yuecideng
force-pushed
the
codex/asset-generalization-sources
branch
from
October 18, 2026 12:15
76ef1bf to
0b08ce2
Compare
yuecideng
force-pushed
the
codex/asset-generalization-sources
branch
from
October 18, 2026 15:49
0b08ce2 to
10b449c
Compare
yuecideng
marked this pull request as ready for review
October 18, 2026 15:50
[Medium impact] The PR appears safe to merge; both previous findings are fixed and no new actionable issues were found. SummaryAdds local asset catalogs with content-addressed snapshots.
No new actionable issues were found. This review checked code and tests; it did not run them.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Add directory and explicit-list providers for annotated rigid asset packages. Validate actual mesh bounds and resource dependencies, publish content-addressed snapshots, and expose common inventory verification for external providers. SimReady metadata can supply category/provenance without implying normalized geometry or task capabilities.
Refs #810. This is layer 2/5 of the currently authorized asset-generalization implementation. PR6 online generation is deferred; no generation service is invoked by this stack.
Stack
codex/asset-generalization-contractsValidation
27 data contract/provider checks passed, including changed source/cache content, textures, path containment, invalid geometry and SimReady annotations. Directory/explicit usage is documented with a complete asset.catalog.json example.
Tests use the repository-pinned DexSim 0.5.1rc1 and its matching Warp 1.17.0 via a process-local dependency path. The workstation's default editable DexSim build has an unrelated import failure; no shared environment installation was modified.
Black 26.3.1 formatting passed. Final-stack API coverage is 2640/2640 exports; the Sphinx dummy build completed with warnings/errors originating in unchanged documentation/docstrings and no diagnostics for the new asset modules. Context review adds the asset-generalization topic and updates component/semantic ownership where behavior changed. Existing data download and scene acceptance guidance remains applicable.
Type of change
Checklist
black .command to format the code base.python docs/scripts/check_api_docs.py).CI collection fix
The asset-catalog tests now form an explicit Python package, avoiding the top-level
test_contractsmodule collision with existing scene-expansion tests under pytest's default import mode. The original two-file collection failure was reproduced before the fix. Combined asset, role, matcher and scene-contract validation passed 94 tests at the third layer; runtime APIs are unchanged. CI passed and PRs #811–#813 were squash-merged together into main. Higher layers remain drafts.Review boundary fixes
Confirmed and fixed the review edge cases: attribute ranking now compares both exact type and value; OBJ/MTL dependency filenames are resolved literally, while glTF keeps URI decoding and package containment. Added limited-result and special-character filename regressions; 63 asset/scene-contract tests passed.