Skip to content

Register DataCollectionGroup and Atlas placeholders using lamella images - #899

Open
tieneupin wants to merge 7 commits into
mainfrom
register-lamella-image
Open

tieneupin wants to merge 7 commits into
mainfrom
register-lamella-image

Conversation

@tieneupin

@tieneupin tieneupin commented Sep 24, 2026 •

Copy link
Copy Markdown
Contributor

PR to add DataCollectionGroup and Atlas registration logic to the lamella image registration workflow. The workflow will now create a placeholder DataCollectionGroup and Atlas in ISPyB for the lamella image if one hasn't already been created by the atlas workflow. A record of that DataCollectionGroup will also stored in Murfey.

We also established that the current method of try-excepting sections of code to return specific logs has bloated the function, and have removed these try-except blocks and their logs. The Murfey database connection is now handled by the context manager in feedback_callback, so the outer try-finally block is also no longer needed.

Actual diff is +113/-77, with the rest of the diff being due to the extension and modification of existing tests.

@tieneupin tieneupin changed the title Register lamella image Register DataCollectionGroup and Atlas placeholders using lamella images Sep 24, 2026
@codecov

codecov Bot commented Sep 24, 2026 •

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 93.10345% with 2 lines in your changes missing coverage. Please review.
✅ Project coverage is 55.21%. Comparing base (ae7931a) to head (b3741e3).

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #899      +/-   ##
==========================================
+ Coverage   55.12%   55.21%   +0.08%     
==========================================
  Files         103      103              
  Lines       11559    11555       -4     
  Branches     1533     1535       +2     
==========================================
+ Hits         6372     6380       +8     
+ Misses       4843     4830      -13     
- Partials      344      345       +1     
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@tieneupin
tieneupin marked this pull request as ready for review September 24, 2026 13:34
@tieneupin tieneupin self-assigned this Sep 24, 2026
@tieneupin tieneupin added enhancement New feature or request server Relates to the server component fib Part of the FIB pipeline extension labels Sep 24, 2026

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request fib Part of the FIB pipeline extension server Relates to the server component

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant