Repository navigation
Remove redundant parser token cloning - #203
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The parser clones each token before adding it to a response. The built-in tokenizer already creates a fresh object for every token, and advancing the parser replaces its current token without modifying previously returned objects.
This removes the four clone operations and lets responses retain the tokens directly.
The following benchmarks compare this change against the implementation after #202, using PHP 8.4.27 and 35,798 synthetic responses per workload. Each result is the average CPU time across three runs.
The measured improvement is small, especially for the numeric-heavy workload where individual runs varied in both directions.
All 920 unit tests pass.
Custom tokenizers that reuse mutable token objects, or retain and later modify emitted tokens, would lose the isolation previously provided by cloning. The built-in tokenizer has neither behavior, and no such custom implementation exists in this repository.
Refs #200.