Repository navigation
Conversation
TIDAL sometimes sends "mediaMetadata": null. parse_track only handled a missing key, so an available track with null metadata raised AttributeError, and Album.parse raised TypeError for any album with null metadata. One such item makes a whole playlist fail to load, as reported in High Tide (Nokse22/high-tide#217, EbbLabs#218). Null is now treated like a missing value. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
TIDAL sometimes sends
"mediaMetadata": nullfor a track or album.parse_trackonly handled the key being missing, so an available track with null metadata raisesAttributeError: 'NoneType' object has no attribute 'get', andAlbum.parseraisesTypeError: 'NoneType' object is not subscriptablefor any album with null metadata. One such item makes a whole playlist fail to load, which is how High Tide users ran into it (Nokse22/high-tide#217, Nokse22/high-tide#218).This treats null like a missing value: tracks get the same empty tags as before, and albums keep their default tags.
Tests: four offline tests in
tests/test_parsing.py, two for null metadata (both fail without the fix) and two checking tags are still read.make lintpasses.🤖 Generated with Claude Code