Skip to content
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
32 changes: 32 additions & 0 deletions tests/test_parsing.py
Original file line number Diff line number Diff line change
Expand Up @@ -198,3 +198,35 @@ def test_track_with_album_parses_album_artist(session):

assert track.album.artist is None
assert track.artist is None


def test_available_track_with_null_media_metadata(session):
track = session.track().parse_track(
track_json(allowStreaming=True, streamReady=True, mediaMetadata=None)
)

assert track.media_metadata_tags == {}


def test_track_media_metadata_tags_are_read(session):
track = session.track().parse_track(
track_json(
allowStreaming=True,
streamReady=True,
mediaMetadata={"tags": ["LOSSLESS", "HIRES_LOSSLESS"]},
)
)

assert track.media_metadata_tags == ["LOSSLESS", "HIRES_LOSSLESS"]


def test_album_with_null_media_metadata_keeps_default_tags(session):
album = session.album().parse(album_json(mediaMetadata=None))

assert album.media_metadata_tags == [""]


def test_album_media_metadata_tags_are_read(session):
album = session.album().parse(album_json(mediaMetadata={"tags": ["LOSSLESS"]}))

assert album.media_metadata_tags == ["LOSSLESS"]
6 changes: 4 additions & 2 deletions tidalapi/album.py
Original file line number Diff line number Diff line change
Expand Up @@ -139,8 +139,10 @@ def parse(
self.audio_quality = json_obj.get("audioQuality")
self.audio_modes = json_obj.get("audioModes")

if "mediaMetadata" in json_obj:
self.media_metadata_tags = json_obj.get("mediaMetadata")["tags"]
# mediaMetadata can be null
media_metadata = json_obj.get("mediaMetadata") or {}
if "tags" in media_metadata:
self.media_metadata_tags = media_metadata["tags"]

self.artist = artist
self.artists = artists
Expand Down
4 changes: 3 additions & 1 deletion tidalapi/media.py
Original file line number Diff line number Diff line change
Expand Up @@ -361,7 +361,9 @@ def parse_track(self, json_obj: JsonObj, album: Album | None = None) -> Track:
if self.available:
self.access_type = json_obj.get("accessType", "None")

self.media_metadata_tags = json_obj.get("mediaMetadata", {}).get("tags", {})
# mediaMetadata can be null
media_metadata = json_obj.get("mediaMetadata") or {}
self.media_metadata_tags = media_metadata.get("tags", {})

self.index = json_obj.get("index")
self.item_uuid = json_obj.get("itemUuid")
Expand Down
Loading