Skip to content

[API] Remove unsupported FastAPI application prefix - #12

Merged
noobHappylife merged 1 commit into
ellm-0.12.0from
fix/fastapi-app-prefix
Nov 18, 2026
Merged

noobHappylife merged 1 commit into
ellm-0.12.0from
fix/fastapi-app-prefix

Conversation

@noobHappylife

@noobHappylife noobHappylife commented Nov 18, 2026 •

Copy link
Copy Markdown

Summary

The API-server image resolves FastAPI 0.162.5, which rejects the prefix argument passed to FastAPI(). The server exits during import before it can answer health checks.

Remove this unsupported, previously ignored constructor argument. Route paths and router prefixes are defined explicitly, so their URLs remain unchanged.

Test plan

  • Reproduced the constructor TypeError in the newly built API-server image.
  • Applied this one-line correction to an isolated container and started the API server with --deploy --foreground.
  • /api/health and /dashboard/ returned HTTP 200; the released SDK's sky.api_info() reported HEALTHY.
  • git diff --check and YAPF 0.32.0 diff check passed. Rebuilt and published v0.12.0-ellm.20261118.3; health, dashboard, and a queued SDK status request passed against that unmodified image.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant