Skip to content

Circularities dev branch - #1547

Draft
tsmbland wants to merge 4 commits into
mainfrom
circularity_two_pass
Draft

tsmbland wants to merge 4 commits into
mainfrom
circularity_two_pass

Conversation

@tsmbland

@tsmbland tsmbland commented Sep 11, 2026 •

Copy link
Copy Markdown
Collaborator

Description

Components:

Fixes # (issue)

Type of change

  • Bug fix (non-breaking change to fix an issue)
  • New feature (non-breaking change to add functionality)
  • Refactoring (non-breaking, non-functional change to improve maintainability)
  • Optimization (non-breaking change to speed up the code)
  • Breaking change (whatever its nature)
  • Documentation (improve or add documentation)

Key checklist

  • All tests pass: $ cargo test
  • The documentation builds and looks OK: $ cargo doc
  • Update release notes for the latest release if this PR adds a new feature or fixes a bug
    present in the previous release

Further checks

  • Code is commented, particularly in hard-to-understand areas
  • Tests added that prove fix is effective or that feature works

@codecov

codecov Bot commented Sep 15, 2026 •

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 91.07143% with 20 lines in your changes missing coverage. Please review.
✅ Project coverage is 90.57%. Comparing base (c8215b8) to head (51aa4a6).

Files with missing lines Patch % Lines
src/simulation/optimisation.rs 45.83% 13 Missing ⚠️
src/simulation/market.rs 95.86% 2 Missing and 3 partials ⚠️
src/output.rs 86.66% 1 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1547      +/-   ##
==========================================
- Coverage   90.84%   90.57%   -0.28%     
==========================================
  Files          61       61              
  Lines        9019     8994      -25     
  Branches     9019     8994      -25     
==========================================
- Hits         8193     8146      -47     
- Misses        507      531      +24     
+ Partials      319      317       -2     

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@tsmbland tsmbland changed the title Circularities v2 Circularities dev branch Sep 21, 2026
@tsmbland
tsmbland force-pushed the circularity_two_pass branch 4 times, most recently from 148ed8b to fda53ec Compare September 21, 2026 14:38

@github-actions github-actions Bot left a comment •

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Performance Alert ⚠️

Possible performance regression was detected for benchmark.
Benchmark result of this commit is worse than the previous benchmark result exceeding threshold 1.30.

Benchmark suite Current: 7ee92d0 Previous: 6a19604 Ratio
example_run/circularity example 670672090 ns 491859145.5 ns 1.36
example_run/missing_commodity example 354109389.5 ns 271642953 ns 1.30
example_run/muse1_default example 475855302 ns 337702386.5 ns 1.41
example_run/two_outputs example 649347473.5 ns 485146523.5 ns 1.34
select_best_assets_parallel/01 13578155.819444444 ns 9132896.765151516 ns 1.49
select_best_assets_parallel/05 39575731.625 ns 26819628.777777776 ns 1.48
select_best_assets_parallel/10 66140711.66666667 ns 45113674.75 ns 1.47
select_best_assets_parallel/15 95735878.5 ns 65351435.33333333 ns 1.46
select_best_assets_parallel/20 127298333.25 ns 85097739.5 ns 1.50
select_best_assets_sequential/01 13697692.979411766 ns 9107675.635526314 ns 1.50
select_best_assets_sequential/05 65514746.33333333 ns 43859325.75 ns 1.49
select_best_assets_sequential/10 131137187 ns 87553632.5 ns 1.50
select_best_assets_sequential/15 195154029 ns 131658938.5 ns 1.48
select_best_assets_sequential/20 260290670 ns 175652280.5 ns 1.48

This comment was automatically generated by workflow using github-action-benchmark.

@tsmbland tsmbland mentioned this pull request Sep 24, 2026
11 tasks
Add feedback process specifier

Use feedback_process parameter to ignore processes in second pass

Use shadow prices in intermediate dispatches
Improvements to feedback recommender
@tsmbland
tsmbland force-pushed the circularity_two_pass branch from c243814 to 7ee92d0 Compare October 14, 2026 12:26

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant