Skip to content

[No QA] Docs updates for E/A#100930 Describe the Approve menu for held expenses - #105318

Merged
stephanieelliott merged 1 commit into
mainfrom
claude-docsApproveHeldExpensesMenu
Oct 30, 2026
Merged

stephanieelliott merged 1 commit into
mainfrom
claude-docsApproveHeldExpensesMenu

Conversation

@MelvinBot

Copy link
Copy Markdown
Contributor

Explanation of Change

Help site update for Clarify Approval Options When Held Expenses Exist On Spend Page.

Incorrect sentence in Approve Expenses:

If a report contains one or more held expenses, clicking Approve (from within the report or from the Reports page) displays a confirmation modal with two options:

What changed: After that PR, selecting Approve on a report with held expenses opens a menu with the Approve only [non-held amount] and Approve [full amount] options. This now happens on Spend > Reports too, not just inside the report. No confirmation modal appears.

This PR edits only that sentence. It also changes "clicking" to "selecting" and "the Reports page" to Spend > Reports, per docs/HELPSITE_NAMING_CONVENTIONS.md. I checked the option labels against src/languages/en.ts (iou.approve, iou.approveOnly).

@mkzie2, please review the files changed and confirm they reflect the current behavior. Then post a new comment saying @MelvinBot mark this PR as ready for review.

Fixed Issues

$ #100930
PROPOSAL:

Tests

// TODO: The human co-author must fill out the tests you ran before marking this PR as "ready for review"
// Please describe what tests you performed that validates your changed worked.

  • Verify that no errors appear in the JS console

Offline tests

QA Steps

// TODO: The human co-author must fill out the QA tests you ran before marking this PR as "ready for review".
// Please describe what QA needs to do to validate your changes and what areas do they need to test for regressions.

  • Verify that no errors appear in the JS console

PR Author Checklist

  • I linked the correct issue in the ### Fixed Issues section above
  • I wrote clear testing steps that cover the changes made in this PR
    • I added steps for local testing in the Tests section
    • I added steps for the expected offline behavior in the Offline steps section
    • I added steps for Staging and/or Production testing in the QA steps section
    • I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
    • I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
    • I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).
  • I included screenshots or videos for tests on all platforms
  • I ran the tests on all platforms & verified they passed on:
    • Android: Native
    • Android: mWeb Chrome
    • iOS: Native
    • iOS: mWeb Safari
    • MacOS: Chrome / Safari
  • I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
  • I verified any copy / text that was added to the app is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
  • If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
  • I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
  • If new assets were added or existing ones were modified, I verified that:
    • The assets are optimized and compressed (for SVG files, run npm run compress-svg)
    • The assets load correctly across all supported platforms.
  • If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
  • If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
  • If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
  • If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
  • If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
    • I verified that all the inputs inside a form are aligned with each other.
    • I added Design label and/or tagged @Expensify/design so the design team can review the changes.
  • If the PR adds or modifies the UI:
    • I asked an AI agent to review the changes for accessibility issues and addressed its findings.
    • I tested with a screen reader (VoiceOver on macOS) and verified all new/changed elements are reachable with a logical focus order.
    • I verified all new/changed elements have meaningful accessible names and roles.
    • I verified state changes are announced (e.g. checked/unchecked, expanded/collapsed, selected).
  • I added unit tests for any new feature or bug fix in this PR to help automatically prevent regressions in this user flow.
  • If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.

Screenshots/Videos

Android: Native
Android: mWeb Chrome
iOS: Native
iOS: mWeb Safari
MacOS: Chrome / Safari

Co-authored-by: mkzie2 <mkzie2@users.noreply.github.com>
@MelvinBot MelvinBot added the HelpDot Apply this label if the issue relates to ExpensifyHelp label Oct 29, 2026
@MelvinBot
MelvinBot requested a review from a team October 29, 2026 01:17
@MelvinBot

Copy link
Copy Markdown
Contributor Author

I created this PR from an upstream branch since I don't have push access to your fork.

To take ownership of this branch and be able to push updates, run:

git remote add upstream https://github.com/Expensify/App.git
git fetch upstream claude-docsApproveHeldExpensesMenu
git checkout -b claude-docsApproveHeldExpensesMenu upstream/claude-docsApproveHeldExpensesMenu
git push -u origin claude-docsApproveHeldExpensesMenu

Then you can close this PR and open a new one from your fork.

@github-actions github-actions Bot changed the title Docs updates for E/A#100930 Describe the Approve menu for held expenses [No QA] Docs updates for E/A#100930 Describe the Approve menu for held expenses Oct 29, 2026
@OSBotify

Copy link
Copy Markdown
Contributor

A preview of your ExpensifyHelp changes have been deployed to https://99ee9094.helpdot.pages.dev ⚡️

Updated articles:

@stephanieelliott
stephanieelliott marked this pull request as ready for review October 30, 2026 21:03
@stephanieelliott
stephanieelliott self-requested a review as a code owner October 30, 2026 21:03
@melvin-bot

melvin-bot Bot commented Oct 30, 2026

Copy link
Copy Markdown

Product reviewer checklist:

  • I have verified the accuracy of the article
    • The article is within a hub that makes sense, and the navigation is correct
    • All processes, screenshots, and examples align with current product behavior.
    • All links within the doc have been verified for correct destination and functionality.
  • I have verified the readability of the article
    • The article's language is clear, concise, and free of jargon.
    • The grammar, spelling, and punctuation are correct.
    • The article contains at least one image, or that an image is not necessary
  • I have verified the formatting of the article
    • The article has consistent formatting (headings, bullet points, etc.) with other HelpDot articles and that aligns with the HelpDot formatting standards.
    • The article has proper text spacing and breaks for readability.
  • I have verified the article has the appropriate tone and style
    • The article's tone is professional, friendly, and suitable for the target audience.
    • The article's tone, terminology, and voice are consistent throughout.
  • I have verified the overall quality of the article
    • The article is not missing any information, nor does it contain redundant information.
    • The article fully addresses user needs.
  • I have verified that all requested improvements have been addressed

For more detailed instructions on completing this checklist, see How do I review a HelpDot PR?

cc @heyjennahay

@melvin-bot
melvin-bot Bot requested review from heyjennahay and removed request for a team October 30, 2026 21:03
@chatgpt-codex-connector

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review 🔄 Running since 2026-10-30T21:03:21.054024Z 614176b Draft marked ready
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@github-actions

Copy link
Copy Markdown
Contributor

HelpDot Documentation Review

Overall Assessment

This PR makes a single, targeted edit to one sentence in Approve-Expenses.md, correcting the described behavior for approving a report that contains held expenses. The change updates the interaction verb, the navigation reference, and the resulting UI element to match current product behavior. The scope is intentionally minimal and the edit is accurate.

Scores Summary

  • Readability: 9/10 - The revised sentence is clear, concise, and scannable. It flows well into the bulleted option list that follows.
  • AI Readiness: 9/10 - Uses full feature-accurate terminology and a bolded navigation path, improving retrieval precision. The edit does not alter heading structure or metadata (outside the diff scope), so no AI-readiness regressions are introduced.
  • Style Compliance: 10/10 - The edit directly implements naming-convention rules: "clicking" to "selecting" (Actions: Select or choose), and "the Reports page" to the bolded navigation path Spend > Reports (Navigation Paths). Replacing "confirmation modal" with "opens a menu" also removes internal UI jargon.

Key Findings

  • The three changes in the single modified line all align with docs/HELPSITE_NAMING_CONVENTIONS.md: correct action verb, correct bolded navigation path with exact segment casing, and plainer language instead of "modal".
  • The option labels (Approve only [non-held amount], Approve [full amount]) were verified by the author against src/languages/en.ts, and the bracketed placeholders are appropriately generic.
  • Note (outside the diff, not scored): the unchanged step at line 41 still reads "Click Approve", which conflicts with the "select" convention now used in the edited sentence. A future pass could align it for consistency.

Recommendations

  • No blocking changes. The proposed edit is accurate and compliant and can proceed.
  • Optional follow-up: in a separate change, update the remaining "Click Approve" instances in this article to "Select Approve" for internal consistency.

Files Reviewed

  • docs/articles/new-expensify/reports-and-expenses/Approve-Expenses.md - One-line edit; accurate and fully compliant with naming conventions.

Note: This is a single-line change, so a top-level summary captures the full review.

@stephanieelliott
stephanieelliott merged commit 4c68ecc into main Oct 30, 2026
26 of 27 checks passed
@stephanieelliott
stephanieelliott deleted the claude-docsApproveHeldExpensesMenu branch October 30, 2026 21:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

HelpDot Apply this label if the issue relates to ExpensifyHelp

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants