Repository navigation
[No QA] Docs updates for E/A#100930 Describe the Approve menu for held expenses - #105318
Conversation
Co-authored-by: mkzie2 <mkzie2@users.noreply.github.com>
|
I created this PR from an upstream branch since I don't have push access to your fork. To take ownership of this branch and be able to push updates, run: Then you can close this PR and open a new one from your fork. |
|
A preview of your ExpensifyHelp changes have been deployed to https://99ee9094.helpdot.pages.dev ⚡️ Updated articles: |
Product reviewer checklist:
For more detailed instructions on completing this checklist, see How do I review a HelpDot PR? cc @heyjennahay |
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
HelpDot Documentation ReviewOverall AssessmentThis PR makes a single, targeted edit to one sentence in Scores Summary
Key Findings
Recommendations
Files Reviewed
Note: This is a single-line change, so a top-level summary captures the full review. |
Explanation of Change
Help site update for Clarify Approval Options When Held Expenses Exist On Spend Page.
Incorrect sentence in Approve Expenses:
What changed: After that PR, selecting Approve on a report with held expenses opens a menu with the Approve only [non-held amount] and Approve [full amount] options. This now happens on Spend > Reports too, not just inside the report. No confirmation modal appears.
This PR edits only that sentence. It also changes "clicking" to "selecting" and "the Reports page" to Spend > Reports, per
docs/HELPSITE_NAMING_CONVENTIONS.md. I checked the option labels againstsrc/languages/en.ts(iou.approve,iou.approveOnly).@mkzie2, please review the files changed and confirm they reflect the current behavior. Then post a new comment saying
@MelvinBot mark this PR as ready for review.Fixed Issues
$ #100930
PROPOSAL:
Tests
// TODO: The human co-author must fill out the tests you ran before marking this PR as "ready for review"
// Please describe what tests you performed that validates your changed worked.
Offline tests
QA Steps
// TODO: The human co-author must fill out the QA tests you ran before marking this PR as "ready for review".
// Please describe what QA needs to do to validate your changes and what areas do they need to test for regressions.
PR Author Checklist
### Fixed Issuessection aboveTestssectionOffline stepssectionQA stepssectionAvatar, I verified the components usingAvatarare working as expected)npm run compress-svg)Avataris modified, I verified thatAvataris working as expected in all cases)Designlabel and/or tagged@Expensify/designso the design team can review the changes.mainbranch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTeststeps.Screenshots/Videos
Android: Native
Android: mWeb Chrome
iOS: Native
iOS: mWeb Safari
MacOS: Chrome / Safari