Repository navigation
feat(Flag Dependency): API support for change requests - #8720
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
2 Skipped Deployments
|
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info
📝 Walkthrough
Merge Risk: ⚪ Minimal · up to
|
a27b281 to
6e1414c
Compare
6e1414c to
8f230b4
Compare
…change-requests-api
…change-requests-api
There was a problem hiding this comment.
Actionable comments posted: 1
ℹ️ Review info
⚙️ Run configuration
- Configuration used: Organization UI
- Review profile: ASSERTIVE
- Plan: Advanced
- Run ID:
d2c684d0-c111-4296-bbe1-7471540bc992
📒 Files selected for processing: 16
api/core/workflows_services.pyapi/environments/urls.pyapi/features/dependencies/exceptions.pyapi/features/dependencies/serializers.pyapi/features/dependencies/services.pyapi/features/dependencies/views.pyapi/features/future/services.pyapi/features/versioning/models.pyapi/features/versioning/tasks.pyapi/pyproject.tomlapi/tests/integration/conftest.pyapi/tests/integration/features/dependencies/conftest.pyapi/tests/integration/features/dependencies/test_change_requests.pyapi/tests/integration/types.pyapi/tests/types.pydocs/docs/deployment-self-hosting/observability/_events-catalogue.md
Included review availability: This review used your included allowance. Your plan provides up to 8 included reviews per hour; 7 remain after this review.
…change-requests-api
khvn26
left a comment
There was a problem hiding this comment.
Chonkier than I'd like, but change requests are what they are, I guess. Left a handful of comments/notes.
Or is it
feat(Change Requests): add API support to flag dependency? 🤷Changes
Closes #8449
Add a new
change_request=Xquery parameter to the flag dependency endpoints:How did you test this code?
A whole bunch of new integration tests exercising the frontend path (#8715).