Skip to content

feat(Flag Dependency): API support for change requests - #8720

Merged
khvn26 merged 21 commits into
mainfrom
feat/flag-dependency-change-requests-api
Oct 16, 2026
Merged

khvn26 merged 21 commits into
mainfrom
feat/flag-dependency-change-requests-api

Conversation

@emyller

@emyller emyller commented Oct 9, 2026 •

Copy link
Copy Markdown
Contributor

Or is it feat(Change Requests): add API support to flag dependency? 🤷

Changes

Closes #8449

Add a new change_request=X query parameter to the flag dependency endpoints:

  • When adding a new prerequisite, it may be staged to a draft change request.
  • When deleting an existing prerequisite, well, same.
  • When listing a features' dependencies, edges are shown as if the change request is live.

How did you test this code?

A whole bunch of new integration tests exercising the frontend path (#8715).

@vercel

vercel Bot commented Oct 9, 2026 •

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated
docs Ready Ready Preview Oct 15, 2026 8:55pm UTC
2 Skipped Deployments
Project Deployment Actions Updated
flagsmith-frontend-preview Ignored Ignored Preview Oct 15, 2026 8:55pm UTC
flagsmith-frontend-staging Ignored Ignored Preview Oct 15, 2026 8:55pm UTC

Request Review

@coderabbitai

coderabbitai Bot commented Oct 9, 2026 •

Copy link
Copy Markdown

Review in Change Stack →

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration
  • Configuration used: Organization UI
  • Review profile: ASSERTIVE
  • Plan: Advanced
  • Run ID: f5dda663-49e9-4f41-b982-314b4d7f646c
📥 Commits

Reviewing files that changed from the base of the PR and between 4827cfe and 7ae78d9.

📒 Files selected for processing: 5
  • api/features/dependencies/permissions.py
  • api/features/dependencies/services.py
  • api/features/dependencies/views.py
  • api/tests/integration/features/dependencies/test_change_requests.py
  • docs/docs/deployment-self-hosting/observability/_events-catalogue.md

Included review availability: This review used your included allowance. Your plan provides up to 8 included reviews per hour; 7 remain after this review.

📝 Walkthrough

The dependency API now supports staging additions and deletions in feature change requests and viewing the staged dependency state. Dependency changes are validated before a request is published. Publishing reports dependency changes and creates associated audit records. Integration tests cover request handling, dependency validation, and immediate or scheduled publication.

Priority: ➖ Normal

Estimated code review effort: 4 (Complex) | ~50 minutes

Merge Risk: ⚪ Minimal · up to 7ae78

No identified issue currently prevents merging after normal checks.

- [ ] Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@github-actions github-actions Bot added api Issue related to the REST API feature New feature or request labels Oct 9, 2026
@emyller
emyller force-pushed the feat/flag-dependency-change-requests-api branch from a27b281 to 6e1414c Compare October 9, 2026 22:29
@github-actions github-actions Bot added feature New feature or request and removed feature New feature or request labels Oct 9, 2026
@emyller
emyller force-pushed the feat/flag-dependency-change-requests-api branch from 6e1414c to 8f230b4 Compare October 9, 2026 22:34
@github-actions github-actions Bot added feature New feature or request and removed feature New feature or request labels Oct 9, 2026
@github-actions github-actions Bot added feature New feature or request and removed feature New feature or request labels Oct 14, 2026
@github-actions github-actions Bot removed the feature New feature or request label Oct 15, 2026

@coderabbitai coderabbitai Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1


ℹ️ Review info
⚙️ Run configuration
  • Configuration used: Organization UI
  • Review profile: ASSERTIVE
  • Plan: Advanced
  • Run ID: d2c684d0-c111-4296-bbe1-7471540bc992
📥 Commits

Reviewing files that changed from the base of the PR and between ff1f862 and 7d0f3e0.

📒 Files selected for processing: 16
  • api/core/workflows_services.py
  • api/environments/urls.py
  • api/features/dependencies/exceptions.py
  • api/features/dependencies/serializers.py
  • api/features/dependencies/services.py
  • api/features/dependencies/views.py
  • api/features/future/services.py
  • api/features/versioning/models.py
  • api/features/versioning/tasks.py
  • api/pyproject.toml
  • api/tests/integration/conftest.py
  • api/tests/integration/features/dependencies/conftest.py
  • api/tests/integration/features/dependencies/test_change_requests.py
  • api/tests/integration/types.py
  • api/tests/types.py
  • docs/docs/deployment-self-hosting/observability/_events-catalogue.md

Included review availability: This review used your included allowance. Your plan provides up to 8 included reviews per hour; 7 remain after this review.

Comment thread api/features/dependencies/views.py Outdated
@github-actions github-actions Bot added docs Documentation updates feature New feature or request and removed feature New feature or request docs Documentation updates labels Oct 15, 2026
@github-actions github-actions Bot added feature New feature or request and removed feature New feature or request labels Oct 15, 2026

@khvn26 khvn26 left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Chonkier than I'd like, but change requests are what they are, I guess. Left a handful of comments/notes.

Comment thread api/core/workflows_services.py
Comment thread api/tests/integration/conftest.py
Comment thread api/tests/integration/features/dependencies/test_change_requests.py
Comment thread api/features/dependencies/views.py Outdated
@github-actions github-actions Bot added feature New feature or request and removed feature New feature or request docs Documentation updates labels Oct 15, 2026
@github-actions github-actions Bot added the docs Documentation updates label Oct 15, 2026
@emyller
emyller requested a review from khvn26 October 15, 2026 20:55
@khvn26 khvn26 changed the title feat(Flag Dependency): add API support to change requests feat(Flag Dependency): API support for change requests Oct 16, 2026

@khvn26 khvn26 left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@khvn26
khvn26 merged commit 9d7907c into main Oct 16, 2026
35 checks passed
@khvn26
khvn26 deleted the feat/flag-dependency-change-requests-api branch October 16, 2026 10:13

This branch was successfully deployed

1 active deployment
Preview – docs — 7ae78d9f Deployed Oct 15, 2026 by vercel[bot]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

api Issue related to the REST API docs Documentation updates feature New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

API support for adding flag dependencies to feature change requests

2 participants