Skip to content

fix: Port TheSuperHackers performance, crash, leak, rendering and window fixes - #638

Open
tintinhamans wants to merge 23 commits into
GeneralsOnlineDevelopmentTeam:mainfrom
tintinhamans:arctic/go/fix/upstream-map-crashes
Open

tintinhamans wants to merge 23 commits into
GeneralsOnlineDevelopmentTeam:mainfrom
tintinhamans:arctic/go/fix/upstream-map-crashes

Conversation

@tintinhamans

@tintinhamans tintinhamans commented Oct 15, 2026 •

Copy link
Copy Markdown

Replaces #640, #641, #633, #636 and #643, closed as folded into this PR. Upstream fixes from TheSuperHackers/GeneralsGameCode, one cherry-pick -x commit each:

MapReaderWriterInfo.h, Recorder.h, GameSpyGameInfo.h and GameWindowManagerScript.cpp exist once per game here and are changed in both. The GameInfo destructor and the ImageCollection fix already exist, so those parts are skipped. Upstream's replay checks passed for every port, and particle templates are not part of the INI CRC, so stock data gives the same ini: value.

z_generals builds, the Generals copies are not compiled. Not run in game.

@tintinhamans
tintinhamans force-pushed the arctic/go/fix/upstream-map-crashes branch from 1f8ec56 to 7f3233f Compare October 22, 2026 21:14
@tintinhamans tintinhamans changed the title fix(terrain): Port merged TheSuperHackers map and terrain fixes fix: Port merged TheSuperHackers map, network, file and handle leak fixes Oct 24, 2026
@tintinhamans tintinhamans changed the title fix: Port merged TheSuperHackers map, network, file and handle leak fixes fix: Port merged TheSuperHackers crash, leak, rendering and window fixes Oct 25, 2026
Mauller and others added 9 commits October 25, 2026 06:44
…ed list has no associated m_info (TheSuperHackers#3113)

(cherry picked from commit 55ccd62)
…I field to control it (TheSuperHackers#3188)

Set VolParticleDepth=1..16 in ParticleSystem INI definitions to configure the depth for volume particles

(cherry picked from commit 45178ee)
@tintinhamans tintinhamans changed the title fix: Port merged TheSuperHackers crash, leak, rendering and window fixes fix: Port TheSuperHackers performance, crash, leak, rendering and window fixes Oct 25, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants