Repository navigation

fix: Port TheSuperHackers performance, crash, leak, rendering and window fixes - #638

Open

tintinhamans wants to merge 40 commits into

GeneralsOnlineDevelopmentTeam:mainfrom

tintinhamans:arctic/go/fix/upstream-map-crashes

Open

fix: Port TheSuperHackers performance, crash, leak, rendering and window fixes#638
tintinhamans wants to merge 40 commits into
GeneralsOnlineDevelopmentTeam:mainfrom
tintinhamans:arctic/go/fix/upstream-map-crashes

Commits on Oct 28, 2026
- bugfix(w3d): Skip rivers that overflow the dynamic index buffer (#3489)
  tintinhamans
  committed
  d53b29c
- fix(worldheightmap): Free the legacy cliff state buffer when loading blend tile data (#3482)
  tintinhamans
  committed
  cfa0c8c
- bugfix(worldheightmap): Reject map sizes that overflow the cell array allocations (#3486)
  tintinhamans
  committed
  ba0eb5d
- fix(lanapi): Fix GameInfo memory leaks in LANAPI::OnGameStart(), LANAPI::RequestGameLeave() (#3462)
  tintinhamans
  committed
  85280dc
- bugfix(network): Close sockets that fail to bind (#3488)
  tintinhamans
  committed
  f424006
- fix(network): Release the disconnect chat message after sending it (#3498)
  tintinhamans
  committed
  12d0f88
- fix(lanapi): Delete the lobby player when they leave the lobby (#3499)
  tintinhamans
  committed
  1ce1722
- fix(addoncompat): Close fullviewport.dat file handle after reading it (#3476)
  tintinhamans
  committed
  bde9e9c
- fix: Close leaked system handles in GameWindowManager, ImageCollection, MainMenuUtils (#3497)
  tintinhamans
  committed
  0f6f0e4
- fix(maputil): Close the file and free the buffer when a map preview copy fails (#3485)
  tintinhamans
  committed
  7833a75
- perf(displaystring): Rebuild static text only when its hotkey setting changes (#3443)
  tintinhamans
  committed
  35a0070
- bugfix(w3d): Fix leaked surface copy in screenshot and movie capture (#3477)
  tintinhamans
  committed
  ba92aba
- bugfix(gamewindow): Remove destroyed windows from the modal stack and prevent duplicate modals for the same window (#3224)
  tintinhamans
  committed
  5bf92eb
- perf(script): Reduce cost of ScriptEngine::findScript() by around 85% (#3096)
  
  Mauller
  authored and
  tintinhamans
  committed
  f1ae9e2
- bugfix(pathfinder): Prevent a retail crash where the head of the closed list has no associated m_info (#3113)
  
  Mauller
  authored and
  tintinhamans
  committed
  97a2f3b
- bugfix(pathfinder): Prevent a retail crash where a pathfindCell has a dangling linked list pointer (#3113)
  
  Mauller
  authored and
  tintinhamans
  committed
  fcc79fb
- bugfix: Prevent the game from freezing during scripted camera movements in multiplayer (#3390)
  tintinhamans
  committed
  c4952d4
- refactor(particlesys): Cleanup retail smudge particle type identification (#3162)
  
  Mauller
  authored and
  tintinhamans
  committed
  dd163b9
- unify(particlesys): Move W3DParticleSys.h to Core (#3172)
  
  stephanmeesters
  authored and
  tintinhamans
  committed
  2e824b7
- tweak(particlesys): Cleanup volume particle depth handling and add INI field to control it (#3188)
  
  Mauller
  authored and
  tintinhamans
  committed
  51cdf13
- perf(particlesys): Batch same type particles to reduce cost of particle rendering by 15 to 30% (#3155)
  
  Mauller
  authored and
  tintinhamans
  committed
  b1be9fa
- bugfix(particlesys): Render lone streak type particles as regular particles (#3320)
  
  Mauller
  authored and
  tintinhamans
  committed
  800e6a6
- bugfix(texturefilter): Fix blocky shroud edges from misconfigured texture filters (#3434)
  
  mirelle7
  authored and
  tintinhamans
  committed
  e11536c
- fix(htree): Reject invalid W3D hierarchy pivot counts (#3195)
  
  CryoTheRenegade
  authored and
  tintinhamans
  committed
  a4541c8
- fix(controlbar): Prevent null dereference in ControlBar::showRallyPoint() if RallyPointMarker was not defined in INI (#3304)
  
  CryoTheRenegade
  authored and
  tintinhamans
  committed
  0417095
- fix(controlbar): Prevent null dereference in ControlBar::updateSpecialPowerShortcut() (#3330)
  
  CryoTheRenegade
  authored and
  tintinhamans
  committed
  3e5fa46
- fix(pointgroup): Prevent null dereference in PointGroupClass::RenderVolumeParticle() when no size array is given (#3280)
  
  CryoTheRenegade
  authored and
  tintinhamans
  committed
  17dec29
- fix(terrainvisual): Prevent null dereference in W3DTerrainVisual::loadRequire() (#3306)
  
  CryoTheRenegade
  authored and
  tintinhamans
  committed
  39c06b0
- fix(modeldraw): Prevent null dereference in W3DModelDraw::handleClientRecoil() (#3301)
  
  CryoTheRenegade
  authored and
  tintinhamans
  committed
  afe0961
- fix(gamewindowtransitions): Prevent null dereference in GameWindowTransitionsHandler::remove() (#3329)
  
  CryoTheRenegade
  authored and
  tintinhamans
  committed
  8e1a8f8
- fix(ini): Prevent using unitialized stack variable in INI::parseBitString8() (#3307)
  
  CryoTheRenegade
  authored and
  tintinhamans
  committed
  d5c69b6
- fix(milesaudiomanager): Prevent heap-buffer-overflow read in MilesAudioManager::selectProvider() (#3281)
  
  CryoTheRenegade
  authored and
  tintinhamans
  committed
  ae2ad15
- fix(firewallhelper): Prevent stack-buffer-overflow write in FirewallHelperClass::getManglerName() (#3346)
  
  CryoTheRenegade
  authored and
  tintinhamans
  committed
  6bdd838
- fix(ww3d2): Copy string setter inputs before freeing potentially aliased storage (#3313)
  
  CryoTheRenegade
  authored and
  tintinhamans
  committed
  f9bb5ae
- fix(audio): Copy SoundSceneObjClass state safely (#3247)
  
  CryoTheRenegade
  authored and
  tintinhamans
  committed
  1b977f7
- fix(gameinfo): Clear GameSlot IP on reset (#3311)
  
  CryoTheRenegade
  authored and
  tintinhamans
  committed
  391029e
- bugfix(debug): Skip system-modal crash dialogs in headless runs (#3030)
  
  bobtista
  authored and
  tintinhamans
  committed
  eef9e3d
- fix(w3ddisplay): Fix cinematic text display string leak (#3517)
  tintinhamans
  committed
  027d4aa
- fix(ingameui): Properly delete ControlBar and ReplayControl game windows on resolution change and/or shutdown (#3414)
  
  xezon
  authored and
  tintinhamans
  committed
  19761e0
- bugfix(pathfinder): Prevent crash in Pathfinder::processHierarchicalCell (#3296)
  
  Caball009
  authored and
  tintinhamans
  committed
  fa57b67

Commits

Commits on Oct 28, 2026