Repository navigation
feat(online): Mount archives by priority and read the data pack layers from settings - #648
Open
tintinhamans wants to merge 9 commits into
Open
tintinhamans wants to merge 9 commits into
tintinhamans wants to merge 9 commits into
Conversation
tintinhamans
force-pushed
the
arctic/go/feat/data-layer
branch
from
October 24, 2026 17:59
b454e9c to
aaea4c1
Compare
…m::openArchiveFile() (TheSuperHackers#3376) (cherry picked from commit 86f2cab)
(cherry picked from commit 5db4f75)
…leSystem, Win32LocalFileSystem (TheSuperHackers#3374) (cherry picked from commit 3f3ed9f)
…ile::getFileInfo(), StdBIGFile::getFileInfo() (TheSuperHackers#3415) (cherry picked from commit b805c12)
…File (TheSuperHackers#3505) Both classes are identical apart from their name and contain no platform specific code. Nothing in them depends on the BIG format either: they open a file from an offset and a size inside the archive file. ArchiveFile takes over their functions and is no longer an abstract class. (cherry picked from commit 52a777a)
…ystem into BIGFileSystem (TheSuperHackers#3505) Both classes are identical apart from their name and go through the local file system for all file access. The one class that remains sits next to ArchiveFileSystem in Core/GameEngine. (cherry picked from commit e4b4d1e)
…e loadBigFilesFromDirectory (TheSuperHackers#3505) loadMods refers to BIG files, which nothing else in ArchiveFileSystem does. It becomes a virtual function that BIGFileSystem implements. loadBigFilesFromDirectory is renamed to loadArchiveFilesFromDirectory, because the base class is not tied to one archive format. (cherry picked from commit f299561)
tintinhamans
force-pushed
the
arctic/go/feat/data-layer
branch
from
October 24, 2026 22:00
aaea4c1 to
e16219c
Compare
tintinhamans
force-pushed
the
arctic/go/feat/data-layer
branch
from
October 24, 2026 22:58
e16219c to
6ef5fa6
Compare
…e Zero Hour archives (cherry picked from commit aaea4c1)
tintinhamans
force-pushed
the
arctic/go/feat/data-layer
branch
from
October 25, 2026 11:15
6ef5fa6 to
1f2a608
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Merge after #653.
Archive priority was an accident of file names, and the core pack and community patch were hard coded. Every archive now has an explicit priority, and
data_packsinsettings.jsonhas three layers:user,generals_onlineandcommunity_patch. From the top the lookup is loose files in the game folder,-mod/-modDir, non-retail BIGs in the game folders,user,generals_online,community_patch, then retail.include_pathsentries are BIGs, folders of BIGs or*.bigpatterns (game:,user:or absolute), mounted in list order with the first one winning.exclude_pathsexists onuseronly. It hides loose files and BIGs of the game folders, never the retail archives. A missing or invalid field keeps its default, and invalid entries are dropped and logged.use_community_data_patchis read once ascommunity_patch.enabledand dropped on save.-disableCommunityDataPatchturns thecommunity_patchlayer off for that launch only. Settings now load before the archives mount. The second commit mounts the Generals data once, where Steam installs used to mount it twice, and ranks it below the Zero Hour archives.scripts/pack_go_data.pybuilds the core BIG.CRC handling is untouched. Deployment: the updater ships
GeneralsOnline_Core.bigto<user data>\GeneralsOnlineGameData\, and the Launcher's community patch checkbox should writedata_packs.community_patch.enabled(the old key is still migrated).