Conversation
…erence Bumps `transformers` (to 5.17.0), `apache-beam[gcp]` (to 2.76.0), `torch` (to 2.12.1), and updates various test dependencies (`google-cloud-aiplatform`, `google-cloud-dataflow-client`, `google-cloud-storage`, `pytest`) to resolve Dependabot security alerts. Also adjusts Python testing versions in `noxfile_config.py`. Note on test failure and deprecation: One test is currently failing due to obsolete usage of pre-built containers which only support up to `torch 2.4`. Rather than repairing this, the sample has been deemed obsolete and is no longer feasible to maintain. A new page in the documentation supersedes this sample: https://docs.cloud.google.com/dataflow/docs/notebooks/run_inference_pytorch The old doc (https://docs.cloud.google.com/dataflow/docs/tutorials/streaming-llm.md) and this sample should both be retired. This deprecation and removal process is being tracked in b/565898242.
product-auto-label
Bot
added
the
samples
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request updates dependency versions in requirements.txt and requirements-test.txt, and modifies the ignored Python versions in noxfile_config.py. Feedback on the pull request suggests updating the ignored_versions list in noxfile_config.py to ensure only the oldest and newest supported Python versions (3.10 and 3.13) are tested, rather than ignoring 3.13 and adding 3.14.
| TEST_CONFIG_OVERRIDE = { | ||
| # You can opt out from the test for specific Python versions. | ||
| "ignored_versions": ["3.8", "3.9", "3.11", "3.12", "3.13"], | ||
| "ignored_versions": ["3.8", "3.9", "3.11", "3.12", "3.14"], |
There was a problem hiding this comment.
According to the project guidelines, we should only test the oldest and newest supported Python releases in the test configurations, ignoring intermediate versions. Since Python 3.13 is the newest supported version and Python 3.10 is the oldest supported version, Python 3.11 and 3.12 should be ignored as intermediate versions, while Python 3.10 and 3.13 should be tested. Please update the ignored_versions list to reflect this.
| "ignored_versions": ["3.8", "3.9", "3.11", "3.12", "3.14"], | |
| "ignored_versions": ["3.8", "3.9", "3.11", "3.12"], |
References
- Only test the oldest and newest supported Python releases in test configurations (such as noxfile_config.py), ignoring intermediate versions.
2 participants
Description
Bumps
transformers(to 5.17.0),apache-beam[gcp](to 2.76.0),torch(to 2.12.1), and updates various test dependencies (google-cloud-aiplatform,google-cloud-dataflow-client,google-cloud-storage,pytest) to resolve Dependabot security alerts. Also adjusts Python testing versions innoxfile_config.py.Note on test failure and deprecation:
One test is currently failing due to obsolete usage of pre-built containers which only support up to
torch 2.4. Rather than repairing this, the sample has been deemedobsolete and is no longer feasible to maintain.
A new page in the documentation supersedes this sample:
https://docs.cloud.google.com/dataflow/docs/notebooks/run_inference_pytorch
The old doc (https://docs.cloud.google.com/dataflow/docs/tutorials/streaming-llm.md) and this sample should both be retired. This deprecation and removal process is being
tracked in b/565898242.
Fixes b/559808079
Checklist
Testing
Compliance & Style
Post-Approval Actions