Skip to content
Draft
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion dataflow/run-inference/noxfile_config.py
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,7 @@

TEST_CONFIG_OVERRIDE = {
# You can opt out from the test for specific Python versions.
"ignored_versions": ["3.8", "3.9", "3.11", "3.12", "3.13"],
"ignored_versions": ["3.8", "3.9", "3.11", "3.12", "3.14"],

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

According to the project guidelines, we should only test the oldest and newest supported Python releases in the test configurations, ignoring intermediate versions. Since Python 3.13 is the newest supported version and Python 3.10 is the oldest supported version, Python 3.11 and 3.12 should be ignored as intermediate versions, while Python 3.10 and 3.13 should be tested. Please update the ignored_versions list to reflect this.

Suggested change
"ignored_versions": ["3.8", "3.9", "3.11", "3.12", "3.14"],
"ignored_versions": ["3.8", "3.9", "3.11", "3.12"],
References
  1. Only test the oldest and newest supported Python releases in test configurations (such as noxfile_config.py), ignoring intermediate versions.

# Old samples are opted out of enforcing Python type hints
# All new samples should feature them
"enforce_type_hints": True,
Expand Down
8 changes: 4 additions & 4 deletions dataflow/run-inference/requirements-test.txt
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
google-cloud-aiplatform==1.158.0
google-cloud-dataflow-client==0.8.14
google-cloud-storage==2.10.0
pytest==9.0.3; python_version >= "3.10"
google-cloud-aiplatform==2.2.0
google-cloud-dataflow-client==0.14.0
google-cloud-storage==3.14.1
pytest==9.1.1
4 changes: 2 additions & 2 deletions dataflow/run-inference/requirements.txt
Original file line number Diff line number Diff line change
@@ -1,3 +1,3 @@
apache-beam[gcp]==2.49.0
apache-beam[gcp]==2.76.0
torch==2.12.1
transformers==5.0.0rc3
transformers==5.17.0
Loading