Repository navigation
root - chore: defense - freeze the lockfile in CI - #166
Conversation
The test, coverage, and release workflows install with pnpm install --frozen-lockfile. The lockfile is committed. Co-authored-by: Jared Wray <me@jaredwray.com>
The checklist names the open pull request. Co-authored-by: Jared Wray <me@jaredwray.com>
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request updates the DEFENSE_IN_DEPTH.md documentation to mark the exotic subdependencies blocking task as completed and indicates that the lockfile freezing PR is pending. The reviewer noted that if this PR is intended to freeze the lockfile in CI, the actual workflow and lockfile changes are missing from the pull request and should be included.
| - [ ] `blockExoticSubdeps: true` (PR #165 pending) | ||
| - [ ] Lockfile committed; CI installs with `pnpm install --frozen-lockfile` | ||
| - [x] `blockExoticSubdeps: true` — PR #165 | ||
| - [ ] Lockfile committed; CI installs with `pnpm install --frozen-lockfile` (PR #166 pending) |
There was a problem hiding this comment.
The pull request title and description state that this PR freezes the lockfile in CI, but the actual changes to the workflow files (e.g., tests.yaml, code-coverage.yaml, release.yaml) and pnpm-lock.yaml are missing from this pull request. Only DEFENSE_IN_DEPTH.md has been modified. Please include the actual workflow and lockfile changes in this PR, and update this line to mark it as completed: - [x] Lockfile committed; CI installs with pnpm install --frozen-lockfile
There was a problem hiding this comment.
The workflow changes are in commit 0e75832. tests.yaml line 42, code-coverage.yaml line 38, and release.yaml line 38 run pnpm install --frozen-lockfile. pnpm-lock.yaml is committed on main. DEFENSE_IN_DEPTH.md line 24 stays open until this pull request merges.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #166 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 9 9
Lines 639 639
Branches 146 151 +5
=========================================
Hits 639 639 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
Summary
This pull request makes CI install with a frozen lockfile in section 3.
Status
DEFENSE_IN_DEPTH.md: frozen lockfile → (PR #166 pending). Exotic subdependencies → PR #165.Verification
pnpm-lock.yamlis committed.tests.yaml,code-coverage.yaml, andrelease.yamlrunpnpm install --frozen-lockfile.pnpm install --frozen-lockfilepasses locally.pnpm buildpasses.b7db701.Reference
defense-in-depth-nodejs § 3