Skip to content

root - chore: defense - freeze the lockfile in CI #166

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jaredwray merged 2 commits into from
Oct 9, 2026
Merged

root - chore: defense - freeze the lockfile in CI #166

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
0e75832
ci: install from the frozen lockfile
cursoragent Oct 9, 2026
b7db701
docs: record pull request 166 on the frozen lockfile item
cursoragent Oct 9, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/workflows/code-coverage.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -35,7 +35,7 @@ jobs:
cache: 'pnpm'

- name: Install Dependencies
run: pnpm install
run: pnpm install --frozen-lockfile

- name: Build
run: pnpm build
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/release.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -35,7 +35,7 @@ jobs:
cache: 'pnpm'

- name: Install Dependencies
run: pnpm install
run: pnpm install --frozen-lockfile

- name: Build
run: pnpm build
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/tests.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -39,7 +39,7 @@ jobs:
cache: 'pnpm'

- name: Install Dependencies
run: pnpm install
run: pnpm install --frozen-lockfile

- name: Build
run: pnpm build
Expand Down
4 changes: 2 additions & 2 deletions DEFENSE_IN_DEPTH.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,8 +20,8 @@ Profile: npm library · public
- [x] 7-day cooldown: `minimumReleaseAge: 10080`, `minimumReleaseAgeStrict: true`, `minimumReleaseAgeIgnoreMissingTime: false`; no first-party `minimumReleaseAgeExclude` — PR #162
- [x] `trustPolicy: no-downgrade`; no first-party `trustPolicyExclude` — PR #163
- [x] Lifecycle scripts blocked: `strictDepBuilds: true`, `dangerouslyAllowAllBuilds: false`, `allowBuilds: {}` baseline — PR #164
- [ ] `blockExoticSubdeps: true` (PR #165 pending)
- [ ] Lockfile committed; CI installs with `pnpm install --frozen-lockfile`
- [x] `blockExoticSubdeps: true` — PR #165
- [ ] Lockfile committed; CI installs with `pnpm install --frozen-lockfile` (PR #166 pending)

@gemini-code-assist gemini-code-assist Bot Oct 9, 2026

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

The pull request title and description state that this PR freezes the lockfile in CI, but the actual changes to the workflow files (e.g., tests.yaml, code-coverage.yaml, release.yaml) and pnpm-lock.yaml are missing from this pull request. Only DEFENSE_IN_DEPTH.md has been modified. Please include the actual workflow and lockfile changes in this PR, and update this line to mark it as completed: - [x] Lockfile committed; CI installs with pnpm install --frozen-lockfile

@cursor cursor Bot Oct 9, 2026

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The workflow changes are in commit 0e75832. tests.yaml line 42, code-coverage.yaml line 38, and release.yaml line 38 run pnpm install --frozen-lockfile. pnpm-lock.yaml is committed on main. DEFENSE_IN_DEPTH.md line 24 stays open until this pull request merges.

- [x] No `.github/dependabot.yml`; other dependency-update tools (if any) open PRs only — never auto-merge — verified 2026-10-08

## 4. GitHub Actions
Expand Down
Loading