Repository navigation
fix(ci): move the org main-source-gate to a GitHub-hosted runner - #13
Merged
Aurora Capital (auroracapital) merged 2 commits intoOct 17, 2026
Merged
Conversation
runs-on [self-hosted, Linux, X64] matched no scale-up queue, because the webhook matcher uses exactMatch with the label set [self-hosted, linux, x64, aws]. The job could only ever land on an already-existing runner, so it never triggered a scale-up and could sit queued until the 24h timeout. Adding the aws label makes the gate trigger its own runner, and keeps it off the aws-large / aws-od fleets.
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
|
You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard. |
The gate lived on [self-hosted, Linux, aws], but this repository is public. GitHub's self-hosted runner guidance is explicit that self-hosted runners should not be used for public repositories, because forks can run workflow code on them. That risk is now closed off: the AWS runner fleet registers in the private-only runner group 'aws-ephemeral-private', and allows_public_repositories is false on the default group. So this public repository can no longer obtain a self-hosted runner at all, which left the gate queued indefinitely. The gate only compares two strings (head repo and head ref), so ubuntu-latest is the correct and cheapest home for it. This also removes the last reason for a public repository to reach the self-hosted fleet.
Aurora Capital (auroracapital)
pushed a commit
that referenced
this pull request
Oct 17, 2026
A self-hosted job whose runs-on omits the fleet label matches no scale-up queue. It therefore never spawns its own runner: it can only land on an instance another job happened to create, and otherwise sits queued until GitHub's 24-hour timeout. That is how the org-wide main-source-gate stalled, and how unmatched events fell through to the on-demand queue. The webhook matcher matches exactly against a fixed label set ([self-hosted, linux, x64, aws] and its siblings), so the label is load-bearing rather than cosmetic. Nothing enforced it. scripts/fleet-label-guard.py parses each workflow and fails when a self-hosted runs-on carries no fleet label. It skips non-self-hosted runners, non-Linux self-hosted runners such as macOS, and expressions that resolve at runtime. Wired into organization-pr-baseline.yml as a blocking step, placed after PyYAML is installed. Depends on #13: main-source-gate omits the label today, so this check is red until #13 lands. The branch is based on #13 for that reason.
Aurora Capital (auroracapital)
deleted the
fix/main-source-gate-aws-label
branch
October 17, 2026 11:32
Aurora Capital (auroracapital)
pushed a commit
that referenced
this pull request
Oct 17, 2026
A self-hosted job whose runs-on omits the fleet label matches no scale-up queue. It therefore never spawns its own runner: it can only land on an instance another job happened to create, and otherwise sits queued until GitHub's 24-hour timeout. That is how the org-wide main-source-gate stalled, and how unmatched events fell through to the on-demand queue. The webhook matcher matches exactly against a fixed label set ([self-hosted, linux, x64, aws] and its siblings), so the label is load-bearing rather than cosmetic. Nothing enforced it. scripts/fleet-label-guard.py parses each workflow and fails when a self-hosted runs-on carries no fleet label. It skips non-self-hosted runners, non-Linux self-hosted runners such as macOS, and expressions that resolve at runtime. Wired into organization-pr-baseline.yml as a blocking step, placed after PyYAML is installed. Depends on #13: main-source-gate omits the label today, so this check is red until #13 lands. The branch is based on #13 for that reason.
Aurora Capital (auroracapital)
added a commit
that referenced
this pull request
Oct 17, 2026
A self-hosted job whose runs-on omits the fleet label matches no scale-up queue. It therefore never spawns its own runner: it can only land on an instance another job happened to create, and otherwise sits queued until GitHub's 24-hour timeout. That is how the org-wide main-source-gate stalled, and how unmatched events fell through to the on-demand queue. The webhook matcher matches exactly against a fixed label set ([self-hosted, linux, x64, aws] and its siblings), so the label is load-bearing rather than cosmetic. Nothing enforced it. scripts/fleet-label-guard.py parses each workflow and fails when a self-hosted runs-on carries no fleet label. It skips non-self-hosted runners, non-Linux self-hosted runners such as macOS, and expressions that resolve at runtime. Wired into organization-pr-baseline.yml as a blocking step, placed after PyYAML is installed. Depends on #13: main-source-gate omits the label today, so this check is red until #13 lands. The branch is based on #13 for that reason. Co-authored-by: Sam Renders <sam.renders@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Probleem
De org-brede
main-source-gatedraaide op een self-hosted runner. Dat kan niet meer, en wel om twee onafhankelijke redenen.1. Deze repository is publiek. GitHub's eigen richtlijn is expliciet: gebruik self-hosted runners niet voor publieke repos, want forks kunnen workflow-code op je runner uitvoeren. Die aanvalsroute is nu dichtgezet: de AWS-fleet registreert in de private-only runner group
aws-ephemeral-private, enallows_public_repositoriesstaat opfalsevoor de default group. Een publieke repo kan dus geen self-hosted runner meer krijgen.Gevolg in de praktijk: op commit
22614f4ableef de gate indefinitely queued. Dat is precies de bug die deze PR zichtbaar maakte.2. actionlint weigert het label.
Organization PR Baselinedraait actionlint 1.7.12, datruns-on-labels valideert tegen GitHub's ingebouwde lijst. Het custom labelawsfaalt daarop:Er is geen
actionlint.yamlin deze repo, dus het label is nergens gedeclareerd.Wijziging
De gate vergelijkt alleen twee strings (
head_repoenhead_ref). Daar is geen self-hosted runner voor nodig, en al helemaal geen AWS-instance.ubuntu-latestis de goedkoopste en veiligste plek.Dit maakt het label-conflict ook moot: geen custom label, dus niets voor actionlint om over te vallen.
Bewijs (A/B op dezelfde check, dezelfde branch)
22614f4a[self-hosted, Linux, aws]c3b59735ubuntu-latestEn de gate zelf draait nu weer: job
PR to main must come from devopGitHub Actions 1001364824, en faalt om de correcte reden (deze branch is nietdev), niet omdat er geen runner is.Historiek
PR #12 zette de gate op self-hosted vanwege een GitHub-hosted spending limit block. Dat block is voorbij:
ubuntu-latestjobs draaien weer normaal in deze org (bewijs: deOrganization PR Baselinejob van deze PR).Context
Onderdeel van de ephemeral runner optimalisatie. Deze PR verwijdert de laatste reden voor een publieke repo om de self-hosted fleet te bereiken.