Repository navigation
Read 2D chemistry probe species after locating the probe - #1989
Closed
sbryngelson wants to merge 3 commits into
Closed
sbryngelson wants to merge 3 commits into
sbryngelson wants to merge 3 commits into
Conversation
In the 2D branch of s_write_probe_files the species partial densities were read from q_cons_vf(j-2, k-2, l) before j, k and l were computed for the current probe and outside the ownership check, so they used the previous probe's cell or, for the first probe, uninitialized indices. A gfortran debug run of a 2D chemistry case with probes aborted on an out-of-bounds index. Move the read inside the ownership branch after the indices are set, as in the 1D and 3D branches.
Member
Author
|
Closing this for now to bring the number of open PRs from me down to four, so the ones that stay open get real review attention rather than being lost in a queue of 35. No work is lost and nothing needs re-doing. The branch I intend to reopen these in small batches as the open slots free up. Apologies for the notification noise. Opened and closed with Claude Code. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In the 2D branch of s_write_probe_files the species partial densities
were read from q_cons_vf(j-2, k-2, l) before j, k and l were computed
for the current probe and outside the ownership check, so they used the
previous probe's cell or, for the first probe, uninitialized indices.
A gfortran debug run of a 2D chemistry case with probes aborted on an
out-of-bounds index.
Move the read inside the ownership branch after the indices are set,
as in the 1D and 3D branches.