Skip to content

Read 2D chemistry probe species after locating the probe - #1989

Closed
sbryngelson wants to merge 3 commits into
MFlowCode:masterfrom
sbryngelson:fix/2d-chem-probe-indices
Closed

sbryngelson wants to merge 3 commits into
MFlowCode:masterfrom
sbryngelson:fix/2d-chem-probe-indices

Conversation

@sbryngelson

@sbryngelson sbryngelson commented Oct 10, 2026 •

Copy link
Copy Markdown
Member

In the 2D branch of s_write_probe_files the species partial densities
were read from q_cons_vf(j-2, k-2, l) before j, k and l were computed
for the current probe and outside the ownership check, so they used the
previous probe's cell or, for the first probe, uninitialized indices.
A gfortran debug run of a 2D chemistry case with probes aborted on an
out-of-bounds index.

Move the read inside the ownership branch after the indices are set,
as in the 1D and 3D branches.

In the 2D branch of s_write_probe_files the species partial densities
were read from q_cons_vf(j-2, k-2, l) before j, k and l were computed
for the current probe and outside the ownership check, so they used the
previous probe's cell or, for the first probe, uninitialized indices.
A gfortran debug run of a 2D chemistry case with probes aborted on an
out-of-bounds index.

Move the read inside the ownership branch after the indices are set,
as in the 1D and 3D branches.
@sbryngelson

Copy link
Copy Markdown
Member Author

Closing this for now to bring the number of open PRs from me down to four, so the ones that stay open get real review attention rather than being lost in a queue of 35.

No work is lost and nothing needs re-doing. The branch fix/2d-chem-probe-indices remains on the fork at 8381419e38, this PR's diff and discussion stay here, and the head commit is additionally archived in a local verified bundle. Reopening takes no force-push and no rebase:

gh pr reopen 1989 -R MFlowCode/MFC

I intend to reopen these in small batches as the open slots free up. Apologies for the notification noise.

Opened and closed with Claude Code.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

1 participant