Repository navigation
Keep every underscore helper of the generated wrappers out of the exports - #49
Merged
estebanzimanyi merged 1 commit intoNov 2, 2026
Conversation
…orts The package's __all__ lists each function functions.py defines except the helpers the generated wrappers call. The generator recognizes such a helper by its leading underscore, so _check_error, _read_string, _take_string and _take_bytes stay private, and so does any helper the template adds later. Witness: __init__.py lists "_read_string", "_take_string" and "_take_bytes" in __all__, so "from pymeos_cffi import *" binds them. Measured: the generator's export step over functions.py (5049 definitions, four with a leading underscore) writes an __init__.py that differs from the committed one by those three names alone, which this change removes.
estebanzimanyi
force-pushed
the
gen/private-helpers-unexported
branch
from
November 2, 2026 08:12
da2a829 to
63ace22
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The package's all lists each function functions.py defines except
the helpers the generated wrappers call. The generator recognizes such a
helper by its leading underscore, so _check_error, _read_string,
_take_string and _take_bytes stay private, and so does any helper the
template adds later.
Witness: init.py lists "_read_string", "_take_string" and
"_take_bytes" in all, so "from pymeos_cffi import *" binds them.
Measured: the generator's export step over functions.py (5049
definitions, four with a leading underscore) writes an init.py that
differs from the committed one by those three names alone, which this
change removes.