Skip to content

Keep every underscore helper of the generated wrappers out of the exports #49

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
estebanzimanyi merged 1 commit into from
Nov 2, 2026
Merged

Keep every underscore helper of the generated wrappers out of the exports #49

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 3 additions & 7 deletions builder/build_pymeos_functions.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -59,12 +59,6 @@ def __init__(self, ctype: str, ptype: str, conversion: str | None) -> None:
self.conversion = conversion


# List of functions defined in functions.py that shouldn't be exported

hidden_functions = [
"_check_error",
]

# List of MEOS functions that should not be defined in functions.py
skipped_functions = [
"py_error_handler",
Expand Down Expand Up @@ -214,7 +208,9 @@ def build_pymeos_functions(idl_path="builder/meos-idl.json", header_path="builde
function_text = ""
for fn in matches:
function_name = fn.group(1)
if function_name in hidden_functions:
# A name with a leading underscore is a helper of the generated wrappers, such
# as _check_error or _take_string, and stays out of the package's exports
if function_name.startswith("_"):
continue
function_text += f" '{function_name}',\n"
functions.append(function_name)
Expand Down
3 changes: 0 additions & 3 deletions pymeos_cffi/__init__.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -35,9 +35,6 @@
"SpatialRelation",
# Functions
"py_error_handler",
"_read_string",
"_take_string",
"_take_bytes",
"create_pointer",
"get_address",
"datetime_to_timestamptz",
Expand Down
Loading