Skip to content

Prepare protocol v0.4.0 response framing migration - #37

Open
nirmalhk7 wants to merge 2 commits into
NTARI-RAND:mainfrom
nirmalhk7:nirmal/protocol-response-framing
Open

nirmalhk7 wants to merge 2 commits into
NTARI-RAND:mainfrom
nirmalhk7:nirmal/protocol-response-framing

Conversation

@nirmalhk7

@nirmalhk7 nirmalhk7 commented Nov 7, 2026 •

Copy link
Copy Markdown
Contributor

This draft prepares Cloudy to consume sohocloud-protocol v0.4.0 from protocol PR #16. The release is still unpublished, so real module checksums and clean tagged-module verification remain unavailable. Keep this PR draft; it is not ready to merge or deploy.

The dependency pin moves from v0.1.0 to v0.4.0. TestCoordinatorResponseFraming exercises real HTTP through Dial and DialAsOperator: whitespace after jobs/fees remains accepted, while a second JSON value is rejected. Existing operator tests cover verifiable authentication headers and fail-closed decoration. The success-body budget remains zero/unbounded; this migration selects no deployment-wide limit.

The agent comment now matches the conformance document: storage opt-in advertisement remains unwired and storage work is still accepted or declined locally. The dependency contains the newer field, so claiming the pinned protocol lacks it was stale. This correction changes no runtime behavior or storage policy.

Verification refreshed on November 16, 2026, using isolated copies of PR head d3d17029e09462673769f17425d4a4b639233558 and current merge tree 8858e4c8c4397940c8de6db6ef9a3dbce24ac869, with the comment correction applied to both:

  • Against protocol candidate d0acd07e56e12c3c95ac98877f040ae3ca79fb00 through external Go workspaces, the full go test -race ./... -count=1, build, vet, and focused constructor regression pass on both trees. Formatting and patch whitespace pass.
  • The same framing regression fails against the actual v0.1.0 module because trailing JSON is silently accepted. This control changes only an isolated copy's pin.
  • Standard golangci-lint 2.12.2 with Go 1.26.10 reports the same 24 findings on current main and the candidate, with zero added findings. Those existing findings remain; this is not a clean-lint or complete Qlty-gate claim.
  • Without a workspace override, go mod download ...@v0.4.0 fails with unknown revision v0.4.0; the clean test command fails on missing module checksums. The GitHub tag lookup also finds no v0.4.0 tag. Candidate-workspace results do not satisfy published-release verification.

The upgrade is not wire-compatible with v0.1.0. Prior GPU/storage additions changed listing and assignment signing bytes under existing v0 domains, even when new fields are empty. The protocol's old-module fixtures demonstrate this incompatibility. An agreed and tested agent, frontend/relay, and coordinator rollout remains required before deployment; this PR adopts no persisted-signature migration policy.

After maintainers review and merge protocol #16 and publish its immutable v0.4.0 tag, acquire the real module checksums and rerun Cloudy's full checks and quality gate without any workspace override. No replacement dependency, fabricated checksum, tag publication, deployment, or Slack workflow update is included. Contributions follow NTARI's Bug-Build-Test guide, fork/PR and DCO requirements. Hosted CI and independent human review remain separate gates; the author must not merge the PR.

Pin the proposed protocol release and add a real HTTP response-framing
regression. Document unpublished-tag verification and the coordinated
upgrade required for legacy listing and assignment signatures.

Signed-off-by: Nirmal Khedkar <nirmalhk7@gmail.com>
Remove the stale statement that the pinned protocol has no storage opt-in field. Keep the existing boundary explicit: this agent does not advertise storage opt-in, and accepts or declines storage work locally. No runtime policy changes.

Candidate-workspace race tests, build, vet and constructor regression pass. Standard lint adds no findings against main. Clean tagged-module verification remains blocked on unpublished protocol v0.4.0.

Signed-off-by: Nirmal Khedkar <nirmalhk7@gmail.com>
@nirmalhk7
nirmalhk7 marked this pull request as ready for review November 17, 2026 19:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant