Repository navigation
Conversation
Add opt-in pre-decoding byte budgets and require one complete JSON response for every client. Preserve current-main signing bytes and document the proposed release and coordinated consumer migration gates. Signed-off-by: Nirmal Khedkar <nirmalhk7@gmail.com>
This was referenced Nov 7, 2026
nirmalhk7
marked this pull request as ready for review
November 16, 2026 19:44
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The reference HTTP client previously accepted trailing JSON values or junk after a successful response and had no configurable success-body size bound. This change requires a complete JSON document for
PollJobsandFeesand adds an opt-inClient.MaxResponseBytesbudget under SPEC §7.1.Positive budgets reject declared overflow before reading and bound streamed reads to the budget plus one detection byte before decoding. Zero leaves size unbounded; negative values fail before transport. Read failures and cancellation propagate, response bodies close, and failures return no partial jobs or fee declaration. Unknown fields remain accepted. The budget also covers ignored successful POST content; the existing error-diagnostic cap remains.
The SPEC, conformance bindings, shared transport fixtures, and migration notes accompany the implementation. Current canonical message bytes, signature domains, endpoints, and the standard-library-only dependency boundary are preserved by this patch.
Verification refreshed on November 16, 2026, on both PR head
d0acd07e56e12c3c95ac98877f040ae3ca79fb00and GitHub's merge tree088cf11077c6f92cff8b65e18c1b25aa52027917against current maincfe78d1399c1f395c77eda0be991b3206dfdb0cf:go test -race ./... -count=1,go vet ./..., andgo build ./...pass, including real chunked signed-fee responses and cancellation while waiting for EOF.python3 testdata/reproduce_spec.pypasses all 55 canonical checks;python3 vectors/reproduce_responses.pypasses all 15 response framing/budget vectors.go list -m alllists only this module; nogo.sumor vendor directory is introduced.Hosted CI and dependency-leaf workflows still require maintainer authorization; local results do not replace those gates. Independent human review remains required, and the author must not merge the PR. Contributions follow NTARI's Bug-Build-Test guide.
Release and deployment are separate from review readiness. Maintainers must publish a new immutable v0.4.0 tag after review and merge before the Cloudy dependency draft and SoHoLINK dependency draft can acquire real checksums and complete tagged-module verification. Existing consumers pin v0.1.0; intervening GPU/storage additions changed listing and assignment signing bytes under existing v0 domains. Old-module fixtures demonstrate that the candidate rejects those signatures. A coordinated agent, frontend/relay, and coordinator rollout must be agreed and verified before deployment. This PR adopts no persisted-signature migration policy, and publishes no tag or deployment.