Repository navigation
Conversation
Pin the proposed protocol release and add a real HTTP response-framing regression. Document unpublished-tag verification and the coordinated upgrade required for legacy listing and assignment signatures. Signed-off-by: Nirmal Khedkar <nirmalhk7@gmail.com>
Merge current main and preserve its response limits, uptime scoring, preflight, and job-history behavior. Migrate lint settings to the v2 schema, retain supported checks and formatting, and document the separate whole-program reachability check. Keep release and migration gates explicit. Signed-off-by: Nirmal Khedkar <nirmalhk7@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This draft prepares SoHoLINK to consume sohocloud-protocol v0.4.0 from protocol PR #16. The release remains unpublished. Real module checksums, clean tagged-module verification, and coordinated migration review remain required; this PR is not ready to merge or deploy.
The dependency pin moves from v0.1.0 to v0.4.0. The real HTTP regression serves a signed fee declaration through SoHoLINK's actual protocol handler: whitespace preserves the signature, while an appended second document is rejected by the strict reference client. Handler authentication, fee terms, and deployment-wide response-body policy are unchanged.
Current main has been merged, preserving its response limits, uptime scoring, preflight, and job-history changes. The broken lint configuration now validates against golangci-lint v2: supported static checks remain enabled and gofmt uses the formatter section. The unsupported deadcode linter is removed; whole-program reachability uses the separate Go deadcode tool, not unused. The conformance note records this distinction and retains the release gate.
Verification refreshed November 17, 2026, at c3f8012 using Go 1.26.10:
go test -race -tags integration -count=1 -p 1 ./...) passes against a disposable TimescaleDB database. Required portal/agent/network unit tests, focused signed-fee framing regression,go build ./..., andgo vet ./...pass.golangci-lint config verifypasses. Complete uncapped lint runs report the same 121 findings on current main and candidate, with zero additions or removals. The separate deadcode runs report identical sets of seven findings. Existing findings remain; this is not a clean-lint claim.git diff --check origin/main...HEADpasses. The repair commit carries a DCO sign-off.unknown revision v0.4.0; the tag lookup also returns not found. Candidate-workspace validation does not satisfy published-release verification. No committed replacement or fabricated checksum is included.The full upgrade is not wire-compatible with v0.1.0. Prior GPU/storage additions changed listing and assignment signing bytes under existing v0 domains, including when new fields are empty. Before deployment, agree and verify a coordinated agent, frontend/relay, and coordinator rollout. This draft adopts no persisted-signature migration policy.
After maintainers merge protocol #16 and publish its immutable v0.4.0 tag, obtain the real checksums and rerun checks without the workspace. Hosted CI and independent human approval remain separate requirements. Contributions follow NTARI's Bug-Build-Test guide; the author must not merge the PR.