Repository navigation
Conversation
The cost.payer_plan_period_id field in the CDM v5.5 Field_Level specification was not flagged as a foreign key, although its convention text describes it as one and payer_plan_period_id is the primary key of PAYER_PLAN_PERIOD. Set isForeignKey, fkTableName and fkFieldName for the row and add the resulting fpk_cost_payer_plan_period_id constraint to the generated 5.5 constraints scripts for every supported dialect.
|
Hi, a gentle ping on this. It marks |
|
@MaximMoinat a follow-up on this and #818, two small spec fixes that are both mergeable:
If either should wait for a particular CDM release, let me know and I'll retarget. |
|
@DG47 Thanks for your contribution. I agree with the change, and I think this should officially be a new build version (i.e. 5.5.1). Is there any time sensitivity for you to implement this change? |
|
@MaximMoinat thanks for looking at it. No time pressure on my side, so shipping it in 5.5.1 works for me. If it helps with the build, I can retarget the branch to wherever 5.5.1 is being collected and add a NEWS.md entry for it. #818, which adds VISIT_DETAIL to the spec's table of contents, could go into the same build. |
The cost.payer_plan_period_id field in the CDM v5.5 Field_Level specification was not flagged as a foreign key, although its convention text describes it as one and payer_plan_period_id is the primary key of PAYER_PLAN_PERIOD. Set isForeignKey, fkTableName and fkFieldName for the row and add the resulting fpk_cost_payer_plan_period_id constraint to the generated 5.5 constraints scripts for every supported dialect.