Skip to content

Add FK from cost.payer_plan_period_id to payer_plan_period (#714) - #814

Open
DG47 wants to merge 2 commits into
OHDSI:mainfrom
DG47:fix/cost-payer-plan-period-fk
Open

DG47 wants to merge 2 commits into
OHDSI:mainfrom
DG47:fix/cost-payer-plan-period-fk

Conversation

@DG47

@DG47 DG47 commented Oct 7, 2026

Copy link
Copy Markdown
Contributor

The cost.payer_plan_period_id field in the CDM v5.5 Field_Level specification was not flagged as a foreign key, although its convention text describes it as one and payer_plan_period_id is the primary key of PAYER_PLAN_PERIOD. Set isForeignKey, fkTableName and fkFieldName for the row and add the resulting fpk_cost_payer_plan_period_id constraint to the generated 5.5 constraints scripts for every supported dialect.

The cost.payer_plan_period_id field in the CDM v5.5 Field_Level
specification was not flagged as a foreign key, although its convention
text describes it as one and payer_plan_period_id is the primary key of
PAYER_PLAN_PERIOD. Set isForeignKey, fkTableName and fkFieldName for the
row and add the resulting fpk_cost_payer_plan_period_id constraint to
the generated 5.5 constraints scripts for every supported dialect.
@DG47

DG47 commented Oct 19, 2026

Copy link
Copy Markdown
Contributor Author

Hi, a gentle ping on this. It marks cost.payer_plan_period_id as a foreign key to PAYER_PLAN_PERIOD in the v5.5 field-level specification (#714). The convention text already describes it that way. If spec changes like this need to wait for a particular release, let me know and I'll retarget the branch.

@DG47

DG47 commented Oct 27, 2026

Copy link
Copy Markdown
Contributor Author

@MaximMoinat a follow-up on this and #818, two small spec fixes that are both mergeable:

If either should wait for a particular CDM release, let me know and I'll retarget.

@MaximMoinat

MaximMoinat commented Oct 28, 2026 •

Copy link
Copy Markdown
Collaborator

@DG47 Thanks for your contribution. I agree with the change, and I think this should officially be a new build version (i.e. 5.5.1).

Is there any time sensitivity for you to implement this change?

@DG47

DG47 commented Oct 28, 2026

Copy link
Copy Markdown
Contributor Author

@MaximMoinat thanks for looking at it. No time pressure on my side, so shipping it in 5.5.1 works for me.

If it helps with the build, I can retarget the branch to wherever 5.5.1 is being collected and add a NEWS.md entry for it. #818, which adds VISIT_DETAIL to the spec's table of contents, could go into the same build.

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants