Bump the maven-dependencies group across 1 directory with 11 updates - #188
dependabot[bot] wants to merge 1 commit into
Conversation
dependabot
Bot
added
dependencies
utafrali
left a comment
utafrali
left a comment
There was a problem hiding this comment.
Two blockers: the checkstyle 14.1.0 upgrade directly contradicts the existing <!-- Last Java 17-compatible line --> comment in both pom.xml and jakarta-test/pom.xml, and bumping the jsp module's Tomcat from 9.0.122 to 11.0.26 will break javax-namespace JSP tests at runtime because Tomcat 11 is jakarta-only. Both need to be resolved before merging.
| <artifactId>checkstyle</artifactId> | ||
| <!-- Last Java 17-compatible line; 13+ requires Java 21. --> | ||
| <version>12.3.1</version> | ||
| <version>14.1.0</version> |
There was a problem hiding this comment.
The comment on the line immediately above this one says <!-- Last Java 17-compatible line; 13+ requires Java 21. -->. This was placed deliberately to pin checkstyle at 12.x because the project's build enforcer only requires Java [17,). Bumping to 14.1.0 will break any CI build running on Java 17, since checkstyle 13+ requires Java 21. Either update the Java requirement to 21 first and update the comment, or pin checkstyle to the latest 12.x release.
| <artifactId>checkstyle</artifactId> | ||
| <!-- Last Java 17-compatible line; 13+ requires Java 21. --> | ||
| <version>12.3.1</version> | ||
| <version>14.1.0</version> |
There was a problem hiding this comment.
Same issue as in the root pom.xml: the existing comment <!-- Last Java 17-compatible line; 13+ requires Java 21. --> explicitly signals that this version must not advance past 12.x without a Java 21 toolchain. Bumping to 14.1.0 here will fail for the same reason.
| <groupId>org.apache.tomcat.embed</groupId> | ||
| <artifactId>tomcat-embed-jasper</artifactId> | ||
| <version>9.0.122</version> | ||
| <version>11.0.26</version> |
There was a problem hiding this comment.
This is a breaking change. The jsp module compiles and tests against javax.* namespace APIs (javax.servlet.jsp-api, javax.el-api, javax.servlet-api). Tomcat 9 was the last major line to serve the javax.* namespace; Tomcat 10 migrated to jakarta.*, and Tomcat 11 is jakarta.*-only with no javax.* support at all. Running the embedded Tomcat 11 jasper engine against javax-namespace JSPs will fail at test time with ClassNotFoundException or NoClassDefFoundError. The correct fix is to keep the jsp module's Tomcat at 9.x (e.g., latest 9.0.x) while the jakarta module correctly advances to 11.x.
| <groupId>jakarta.el</groupId> | ||
| <artifactId>jakarta.el-api</artifactId> | ||
| <version>4.0.0</version> | ||
| <version>6.0.1</version> |
There was a problem hiding this comment.
jakarta.el-api jumps from 4.0.0 (Jakarta EE 9 / EL 4) directly to 6.0.1 (Jakarta EE 11 / EL 6), skipping 5.0 (Jakarta EE 10). This aligns with the Tomcat 10.1 → 11.0 upgrade in this same module, so the versions are internally consistent. Just worth confirming that the test suite does not need to demonstrate EL 5.0 compatibility, since that generation was never exercised here.
Bumps the maven-dependencies group with 11 updates in the / directory: | Package | From | To | | --- | --- | --- | | [org.codehaus.plexus:plexus-utils](https://github.com/codehaus-plexus/plexus-utils) | `3.6.2` | `4.1.0` | | [com.puppycrawl.tools:checkstyle](https://github.com/checkstyle/checkstyle) | `12.3.1` | `14.1.0` | | org.apache.felix:maven-bundle-plugin | `6.1.2` | `6.2.0` | | [javax.servlet.jsp:javax.servlet.jsp-api](https://github.com/javaee/javaee-jsp-api) | `2.2.1` | `2.3.3` | | javax.el:javax.el-api | `2.2.5` | `3.0.0` | | [javax.servlet:javax.servlet-api](https://github.com/javaee/servlet-spec) | `3.0.1` | `4.0.1` | | org.apache.tomcat.embed:tomcat-embed-jasper | `9.0.122` | `11.0.26` | | org.apache.tomcat:tomcat-annotations-api | `9.0.122` | `11.0.26` | | [jakarta.servlet.jsp:jakarta.servlet.jsp-api](https://github.com/eclipse-ee4j/jsp-api) | `3.0.0` | `4.0.0` | | [jakarta.el:jakarta.el-api](https://github.com/eclipse-ee4j/el-ri) | `4.0.0` | `6.0.1` | | [jakarta.servlet:jakarta.servlet-api](https://github.com/eclipse-ee4j/servlet-api) | `6.0.0` | `6.1.0` | Updates `org.codehaus.plexus:plexus-utils` from 3.6.2 to 4.1.0 - [Release notes](https://github.com/codehaus-plexus/plexus-utils/releases) - [Commits](codehaus-plexus/plexus-utils@plexus-utils-3.6.2...plexus-utils-4.1.0) Updates `com.puppycrawl.tools:checkstyle` from 12.3.1 to 14.1.0 - [Release notes](https://github.com/checkstyle/checkstyle/releases) - [Commits](checkstyle/checkstyle@checkstyle-12.3.1...checkstyle-14.1.0) Updates `org.apache.felix:maven-bundle-plugin` from 6.1.2 to 6.2.0 Updates `javax.servlet.jsp:javax.servlet.jsp-api` from 2.2.1 to 2.3.3 - [Release notes](https://github.com/javaee/javaee-jsp-api/releases) - [Commits](javaee/javaee-jsp-api@jsp-impl-2.2.1...javax.servlet.jsp-api-2.3.3) Updates `javax.el:javax.el-api` from 2.2.5 to 3.0.0 Updates `javax.servlet:javax.servlet-api` from 3.0.1 to 4.0.1 - [Commits](javaee/servlet-spec@3.0.1...4.0.1) Updates `org.apache.tomcat.embed:tomcat-embed-jasper` from 9.0.122 to 11.0.26 Updates `org.apache.tomcat:tomcat-annotations-api` from 9.0.122 to 11.0.26 Updates `jakarta.servlet.jsp:jakarta.servlet.jsp-api` from 3.0.0 to 4.0.0 - [Release notes](https://github.com/eclipse-ee4j/jsp-api/releases) - [Commits](jakartaee/pages@3.0.0-RELEASE...4.0.0-RELEASE) Updates `jakarta.el:jakarta.el-api` from 4.0.0 to 6.0.1 - [Release notes](https://github.com/eclipse-ee4j/el-ri/releases) - [Commits](https://github.com/eclipse-ee4j/el-ri/commits) Updates `jakarta.servlet:jakarta.servlet-api` from 6.0.0 to 6.1.0 - [Commits](jakartaee/servlet@6.0.0-RELEASE...6.1.0-RELEASE) --- updated-dependencies: - dependency-name: com.puppycrawl.tools:checkstyle dependency-version: 14.1.0 dependency-type: direct:production update-type: version-update:semver-major dependency-group: maven-dependencies - dependency-name: jakarta.el:jakarta.el-api dependency-version: 6.0.1 dependency-type: direct:development update-type: version-update:semver-major dependency-group: maven-dependencies - dependency-name: jakarta.servlet.jsp:jakarta.servlet.jsp-api dependency-version: 4.0.0 dependency-type: direct:production update-type: version-update:semver-major dependency-group: maven-dependencies - dependency-name: jakarta.servlet:jakarta.servlet-api dependency-version: 6.1.0 dependency-type: direct:development update-type: version-update:semver-minor dependency-group: maven-dependencies - dependency-name: javax.el:javax.el-api dependency-version: 3.0.0 dependency-type: direct:development update-type: version-update:semver-major dependency-group: maven-dependencies - dependency-name: javax.servlet.jsp:javax.servlet.jsp-api dependency-version: 2.3.3 dependency-type: direct:production update-type: version-update:semver-minor dependency-group: maven-dependencies - dependency-name: javax.servlet:javax.servlet-api dependency-version: 4.0.1 dependency-type: direct:development update-type: version-update:semver-major dependency-group: maven-dependencies - dependency-name: org.apache.felix:maven-bundle-plugin dependency-version: 6.2.0 dependency-type: direct:production update-type: version-update:semver-minor dependency-group: maven-dependencies - dependency-name: org.apache.tomcat.embed:tomcat-embed-jasper dependency-version: 11.0.26 dependency-type: direct:production update-type: version-update:semver-major dependency-group: maven-dependencies - dependency-name: org.apache.tomcat:tomcat-annotations-api dependency-version: 11.0.26 dependency-type: direct:production update-type: version-update:semver-major dependency-group: maven-dependencies - dependency-name: org.codehaus.plexus:plexus-utils dependency-version: 4.1.0 dependency-type: direct:production update-type: version-update:semver-major dependency-group: maven-dependencies ... Signed-off-by: dependabot[bot] <support@github.com>
1de0911 to
37e5e6c
Compare
|
Replaced by focused PR #191 and the complete dependency disposition record. Bundle Plugin 6.2.0 is the accepted candidate: fresh clean verify, original-JAR JPMS/OSGi consumers, 17 artifact guards and two independent 17-payload comparisons passed. The only changed binary entry contents are the expected manifest Created-By versions. Final reviews and all required CI still gate #191's merge. The rest are explicitly deferred: Checkstyle 14 requires Java 21 and fails our JDK 17 build; Tomcat 11 breaks the javax engine; public API dependency and minimum-fixture changes need a separate compatibility decision; Plexus Utils 4 needs separate plugin-realm migration/signing evidence. Existing patched publisher dependencies remain in place. These are not blanket advisory dismissals or permanent version ignores. #191 also separates eleven baseline-sensitive coordinates from the broad version-update group, while preserving individual proposals and the security-update group. Closing this mixed failing PR as superseded avoids conflating compatible maintenance with baseline changes. #169 records the cleanup. |
|
This pull request was built based on a group rule. Closing it will not ignore any of these versions in future pull requests. To ignore these dependencies, configure ignore rules in dependabot.yml |
2 participants
Bumps the maven-dependencies group with 11 updates in the / directory:
3.6.24.1.012.3.114.1.06.1.26.2.02.2.12.3.32.2.53.0.03.0.14.0.19.0.12211.0.269.0.12211.0.263.0.04.0.04.0.06.0.16.0.06.1.0Updates
org.codehaus.plexus:plexus-utilsfrom 3.6.2 to 4.1.0Release notes
Sourced from org.codehaus.plexus:plexus-utils's releases.
... (truncated)
Commits
572ce90[maven-release-plugin] prepare release plexus-utils-4.1.0077e801Bump the plexus dependencies released today840a1b4Update parent to plexus 279c560faDrop the Publish Site workflow5f96b03Bump org.codehaus.plexus:plexus from 25 to 264846c05Add the Publish Site workflow4df3a86Use the shared release-drafter config instead of a local copy9eb5fc6Apply spotless formatting to READMEf2856f9Rewrite README with usage, status and version guidance62fe2faBump release-drafter/release-drafter from 7.6.0 to 7.7.0Updates
com.puppycrawl.tools:checkstylefrom 12.3.1 to 14.1.0Release notes
Sourced from com.puppycrawl.tools:checkstyle's releases.
... (truncated)
Commits
1bfc2e2[maven-release-plugin] prepare release checkstyle-14.1.0bdf617fdoc: release notes for 14.1.0ae866b2Issue #12189: Test ArchUnit unnecessary suppressions88ab43fIssue #21229: Align AtclauseOrder examples with property counta2703ceIssue #21229: Align LineEnding examples with property count8d88ee0Issue #20692: Add new check ExpressionOverBlockLambda07e06a6Issue #21229: Align JavadocBlockTagLocation examples with property count4205f8dIssue #21393: Improper indentation in property_types.html code snippetsee4191bIssue #21062: Add InappropriateJavadocBlockTagsOnField check47b4b77Issue #13159: naming convention change for xdoc filesUpdates
org.apache.felix:maven-bundle-pluginfrom 6.1.2 to 6.2.0Updates
javax.servlet.jsp:javax.servlet.jsp-apifrom 2.2.1 to 2.3.3Commits
80b323b[maven-release-plugin] prepare for next development iteration2cb1653[maven-release-plugin] prepare release 2.3.3e41363fUpdate scm/plugin version13d7122javaee-api-api/issue55 NullPointerException is thrown if application doesn't ...3c6b171javaee-jsp-api/issues53 NullPointerException is thrown if tld file doesn't in...0c4d240javaee-jsp-api/issues54 Failed to compile jsp files in which custom tags are ...4134c36Update CONTRIBUTING.md2614390Create LICENSEfbc02a2revert test versions4b09002[maven-release-plugin] prepare for next development iterationUpdates
javax.el:javax.el-apifrom 2.2.5 to 3.0.0Updates
javax.servlet:javax.servlet-apifrom 3.0.1 to 4.0.1Commits
5574e9b[maven-release-plugin] prepare release 4.0.16430adaUpdate pom with latest copyright plugin version7265df0Copyright changes. (#192)9a27193[maven-release-plugin] prepare for next development iterationef2740a[maven-release-plugin] prepare release 4.0.062e5c39update the version to 4.0.0-SNAPSHOT10f86f3Update Bundle-License MANIFEST.MF property779f324fix typo in skip test8ecb128Remove watermark, and add preposition where needed8c36beeFix typo. Insert preposition "to" after "corresponding" as necessary.Updates
org.apache.tomcat.embed:tomcat-embed-jasperfrom 9.0.122 to 11.0.26Updates
org.apache.tomcat:tomcat-annotations-apifrom 9.0.122 to 11.0.26Updates
jakarta.servlet.jsp:jakarta.servlet.jsp-apifrom 3.0.0 to 4.0.0Commits
f723f99Prepare release jakarta.servlet.jsp:jakarta.servlet.jsp-api:4.0.0539dadfUpdate copyright year in Javadoc91ccb19POM version should be SNAPSHOT65e89c3Add dependency required to run the tests4e0416bFix compilation warnings254f435Various POM fixes3956175Merge pull request #266 from alwin-joseph/tck_rem_snapshotmodules6a1b235set jdk17 as compiler source/target8abee4fuse M1 modules of jakarta.tck projectdda566dpages tck documentation for 4.0Updates
jakarta.el:jakarta.el-apifrom 4.0.0 to 6.0.1Release notes
Sourced from jakarta.el:jakarta.el-api's releases.
Commits
Updates
jakarta.servlet:jakarta.servlet-apifrom 6.0.0 to 6.1.0Commits
fe6e12aPrepare release jakarta.servlet:servlet-parent:6.1.0b09f123Add missing JARs to webapp - Part of fix for #638e93b9bfRemove unused code. Part of fix for #63804ad5c7Update copyright date used in Javadoc footer3154612Remove text incorrectly added when originally addressing #18314c6edRevert Dependabot's JRuby update - it breaks the spec build28a4bbe---7a912a8---72d4380---f203652Merge pull request #635 from jakartaee/dependabot/maven/org.apache.maven.plug...