Repository navigation
Receivers take the components that split windows and layers (0.4.0) - #33
Merged
Merged
Conversation
…0.3.5 The Fiji window grouping and the napari route key re-read zmqruntime's flat ViewerComponentMode enum. The calling viewer now passes the components its own slot family places in separate windows or layers, so these helpers name no viewer vocabulary. normalize_component_layout (test-only) and the NapariDisplayWireField/FijiDisplayWireField rosters (the OpenHCS display settings dataclasses are the wire keys now) are deleted. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
The receiver API change is breaking, and zmqruntime 0.5 deletes the mode enum these receivers used to read. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
trissim
changed the title
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Lockstep with OpenHCS G6 (domain-blind viewers) and ZMQRuntime #27.
group_items_into_windows(items, display_layout, window_components)replacesgroup_items_by_component_modes: the caller (the OpenHCS Fiji viewer, from its own slot family) passes the components that get a window each.GroupedWindowItemsdrops the channel/slice/frame lists the helper only passed through.build_route_key(..., layer_components, ...)takes the napari layer components instead of reading the flatViewerComponentMode.normalize_component_layout(test-only),NapariDisplayWireField,FijiDisplayWireField(only OpenHCS used them; the OpenHCS display-settings dataclass fields are the wire keys now).Version bumped to 0.4.0 (breaking) with
zmqruntime>=0.5.0,<0.6; not tagged. Do not merge before the OpenHCS G6 PR.Tests: full PolyStore suite 588 passed, 2 skipped.
🤖 Generated with Claude Code