Repository navigation
Preserve authored nested dataclass types in clean generated source - #2
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Clean mode silently dropped an authored nested dataclass subtype when all of the subtype's own fields matched its defaults. The parent's default constructor then recreated a different nominal type. An OpenHCS configuration containing
VolumeSourceSpatialDomain()consequently rendered asGlobalPipelineConfig()and reopened as an XY declaration.The existing generic formatter only omits an empty nested constructor when its nominal owner matches the field's default owner. Ordinary unchanged defaults still disappear from clean source. No application-specific formatter or subtype roster is added.
Validation: the complete existing suite plus three focused controls passed (12 tests). Two controls reproduced the loss before the fix, covering both extra subtype fields and a semantic subtype with no additional fields. Actual public OpenHCS ConfigDocument roundtrips retain both default-valued and explicit-depth volume declarations. An actual original 31-step 3D PipelineDocument source roundtrip also preserves the intrinsic type and all three image source bindings, jointly checked through ObjectState's independent runtime-owner fix.
Joint production qualification: the full original 31-step 3D pipeline passes public source decoding, orchestrator initialization using its actual 180-reference source index, and compilation to
CompiledExecutionBundleon OpenHCS2b9bb5649. No pipeline execution or performance result is claimed.Closes #1