Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion src/pycodify/formatters.py
Original file line number Diff line number Diff line change
Expand Up @@ -328,7 +328,11 @@ def _format_dataclass_expression(
current_value,
field_ctx,
)
if context.clean_mode and not nested_has_fields:
if (
context.clean_mode
and not nested_has_fields
and type(current_value) is type(default_value)
):
continue
imports |= nested_imports
lines.append(f"{field_name}={nested_code}")
Expand Down
32 changes: 31 additions & 1 deletion tests/test_core.py
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
"""Tests for pycodify.core module."""

import pytest
from dataclasses import dataclass
from dataclasses import dataclass, field
from enum import Enum
from types import MappingProxyType

Expand Down Expand Up @@ -29,6 +29,36 @@ class SimpleConfig:
enabled: bool = True


@dataclass
class VolumeConfig(SimpleConfig):
depth: int = 60


@dataclass
class NominalConfig(SimpleConfig):
pass


@dataclass
class NestedConfig:
image: SimpleConfig = field(default_factory=SimpleConfig)


@pytest.mark.parametrize("image_type", [VolumeConfig, NominalConfig])
def test_clean_nested_defaults_preserve_authored_nominal_owner(image_type):
config = NestedConfig(image=image_type())
source = generate_python_source(Assignment("config", config), clean_mode=True)
namespace = {}
exec(source, namespace)
assert type(namespace["config"].image) is image_type
assert namespace["config"] == config


def test_clean_nested_unchanged_default_remains_omitted():
source = generate_python_source(Assignment("config", NestedConfig()), clean_mode=True)
assert "image=" not in source


class ExtensionProbe:
pass

Expand Down
Loading