Repository navigation
Fix buffer size calculation and bounds checks in ppdEmitString - #92
Open
RanjanKumar-rj wants to merge 1 commit into
Open
RanjanKumar-rj wants to merge 1 commit into
RanjanKumar-rj wants to merge 1 commit into
Conversation
Update the Pass-1 buffer size estimation in ppdEmitString() to account
for the maximum formatted length of floating-point custom parameters
emitted by _ppdStrFormatd() ("%.12f").
Additionally, replace the unbounded memcpy() of option code strings in
Pass-2 with strlcpy() and guard trailing newline writes against buffer
end bounds so bufptr cannot advance past bufend.
Signed-off-by: Ranjan Kumar <kumarranja@chromium.org>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Update the Pass-1 buffer size estimation in ppdEmitString() to account for the maximum formatted length of floating-point custom parameters emitted by _ppdStrFormatd() ("%.12f").
Additionally, replace the unbounded memcpy() of option code strings in Pass-2 with strlcpy() and guard trailing newline writes against buffer end bounds so bufptr cannot advance past bufend.
Closes #84