Skip to content

Fix buffer size calculation and bounds checks in ppdEmitString #92

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
tillkamppeter merged 1 commit into from
Oct 29, 2026
Merged

Fix buffer size calculation and bounds checks in ppdEmitString #92

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
22 changes: 12 additions & 10 deletions ppd/ppd-emit.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -669,7 +669,7 @@ ppdEmitString(ppd_file_t *ppd, // I - PPD file record
ppd_section_t section, // I - Section to write
float min_order) // I - Lowest OrderDependency
{
int i, j, // Looping vars
int i, // Looping vars
count; // Number of choices
ppd_choice_t **choices; // Choices
ppd_size_t *size; // Custom page size
Expand Down Expand Up @@ -736,7 +736,7 @@ ppdEmitString(ppd_file_t *ppd, // I - PPD file record
case PPD_CUSTOM_POINTS :
case PPD_CUSTOM_REAL :
case PPD_CUSTOM_INT :
bufsize += 10;
bufsize += 56; // "%.12f" of ±FLT_MAX <= 53 chars + '\n' + slack
break;

case PPD_CUSTOM_PASSCODE :
Expand All @@ -760,7 +760,7 @@ ppdEmitString(ppd_file_t *ppd, // I - PPD file record
DEBUG_puts("2ppdEmitString: Custom size set!");

bufsize += 37; // %%BeginFeature: *CustomPageSize True\n
bufsize += 50; // Five 9-digit numbers + newline
bufsize += 5 * 56; // 5 * ("%.12f" of ±FLT_MAX <= 53 chars + '\n' + slack)
}
else if (!_ppd_strcasecmp(choices[i]->choice, "Custom") &&
(coption = ppdFindCustomOption(ppd,
Expand All @@ -785,7 +785,7 @@ ppdEmitString(ppd_file_t *ppd, // I - PPD file record
case PPD_CUSTOM_POINTS :
case PPD_CUSTOM_REAL :
case PPD_CUSTOM_INT :
bufsize += 10;
bufsize += 56; // "%.12f" of ±FLT_MAX <= 53 chars + '\n' + slack
break;

case PPD_CUSTOM_PASSCODE :
Expand Down Expand Up @@ -1045,7 +1045,8 @@ ppdEmitString(ppd_file_t *ppd, // I - PPD file record
for (pos = 0; pos < 5; pos ++)
{
bufptr = _ppdStrFormatd(bufptr, bufend, values[pos], loc);
*bufptr++ = '\n';
if (bufptr < bufend)
*bufptr++ = '\n';
}

if (!choices[i]->code)
Expand Down Expand Up @@ -1099,7 +1100,8 @@ ppdEmitString(ppd_file_t *ppd, // I - PPD file record
case PPD_CUSTOM_REAL :
bufptr = _ppdStrFormatd(bufptr, bufend,
cparam->current.custom_real, loc);
*bufptr++ = '\n';
if (bufptr < bufend)
*bufptr++ = '\n';
break;

case PPD_CUSTOM_INT :
Expand Down Expand Up @@ -1146,11 +1148,11 @@ ppdEmitString(ppd_file_t *ppd, // I - PPD file record

if (choices[i]->code && choices[i]->code[0])
{
j = (int)strlen(choices[i]->code);
memcpy(bufptr, choices[i]->code, (size_t)j);
bufptr += j;
size_t codelen = strlen(choices[i]->code);
strlcpy(bufptr, choices[i]->code, (size_t)(bufend - bufptr + 1));
bufptr += strlen(bufptr);

if (choices[i]->code[j - 1] != '\n')
if (choices[i]->code[codelen - 1] != '\n' && bufptr < bufend)
*bufptr++ = '\n';
}

Expand Down
Loading