Skip to content

fix(audit): log many-to-many collection changes on registration entities - #669

Open
romanetar wants to merge 4 commits into
fix/audit-m2m-cfp-typesfrom
fix/audit-m2m-registration
Open

romanetar wants to merge 4 commits into
fix/audit-m2m-cfp-typesfrom
fix/audit-m2m-registration

Conversation

@romanetar

@romanetar romanetar commented Nov 10, 2026 •

Copy link
Copy Markdown
Collaborator

ref: https://app.clickup.com/t/9014802374/86bc72z5c

Summary

Part of a stack of 5 PRs that make every configured audit formatter handle many-to-many collection changes (ADR-004). Without a case for EVENT_COLLECTION_MANYTOMANY_UPDATE / DELETE, a configured formatter returns null and AuditLogOtlpStrategy drops the entry, so attaching or detaching items left no audit trail.

Covers: SummitBadgeType (access_levels, badge_features, allowed_view_types), SummitAttendeeBadge (features), SummitOrderExtraQuestionType (allowed_ticket_types, allowed_badge_features_types) and SummitTaxType (ticket_types).

One commit per formatter, each with its tests under tests/OpenTelemetry/Formatters/ (update with added and removed ids, delete with preloaded deleted_ids, and null when there is no diff).

Stack

Review in order; each PR is green on its own. The coverage guard test and the ADR-004 update land in the last PR (#671).

  1. fix(audit): log many-to-many collection changes on CFP selection entities #667 CFP: selection plans, track chairs, invitations, categories, speakers
  2. fix(audit): log many-to-many collection changes on CFP type entities #668 CFP: presentation types, event types, media upload types, documents
  3. fix(audit): log many-to-many collection changes on registration entities #669 Registration: badge types, attendee badges, extra questions, tax types
  4. fix(audit): log many-to-many collection changes on promo and discount codes #670 Promo and discount codes
  5. fix(audit): log many-to-many collection changes on summit, sponsor and venue rooms and add coverage guard #671 Summit, sponsor, venue rooms + guard test + ADR-004

🤖 Generated with Claude Code

@coderabbitai

coderabbitai Bot commented Nov 10, 2026 •

Copy link
Copy Markdown

Important

  • Trigger review

This repository does not receive automatic reviews because it has fewer than 10 stars.

Run configuration

  • Source mode: Auto
  • Repository: Unavailable
  • Branch: Unavailable
  • File: No configuration file from this repository applied
  • Commit: Unavailable
  • Layers: defaults
  • Review profile: CHILL
  • Plan: Advanced
  • Run ID: dadf4a6a-3409-41e1-a87c-6f690cdb5d4a
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

Share

@github-actions

Copy link
Copy Markdown

📘 OpenAPI / Swagger preview

➡️ https://OpenStackweb.github.io/summit-api/openapi/pr-669/

This page is automatically updated on each push to this PR.

access_levels, badge_features and allowed_view_types now report added and removed ids through SummitBadgeTypeAuditLogFormatter instead of being dropped (ADR-004).
features now reports added and removed ids through SummitAttendeeBadgeAuditLogFormatter instead of being dropped (ADR-004).
allowed_ticket_types and allowed_badge_features_types now report added and removed ids through SummitOrderExtraQuestionTypeAuditLogFormatter instead of being dropped (ADR-004).
ticket_types now reports added and removed ids through SummitTaxTypeAuditLogFormatter instead of being dropped (ADR-004).
@romanetar
romanetar force-pushed the fix/audit-m2m-registration branch from a7a6b52 to 3b382a6 Compare November 10, 2026 13:10
@github-actions

Copy link
Copy Markdown

📘 OpenAPI / Swagger preview

➡️ https://OpenStackweb.github.io/summit-api/openapi/pr-669/

This page is automatically updated on each push to this PR.

@romanetar
romanetar marked this pull request as ready for review November 10, 2026 13:15
@romanetar
romanetar requested a review from smarcet November 10, 2026 14:10

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant