Repository navigation
Conversation
|
Important
This repository does not receive automatic reviews because it has fewer than 10 stars.
|
|
📘 OpenAPI / Swagger preview ➡️ https://OpenStackweb.github.io/summit-api/openapi/pr-670/ This page is automatically updated on each push to this PR. |
…codes badge_features, allowed_ticket_types and tags now report added and removed ids through PrePaidSummitRegistrationDiscountCodeAuditLogFormatter instead of being dropped (ADR-004). The handler lives in the FormatsRegistrationCodeManyToManyCollections trait so the other registration code formatters can share it, as done for presentations.
…odes badge_features, allowed_ticket_types and tags now report added and removed ids through SponsorSummitRegistrationDiscountCodeAuditLogFormatter instead of being dropped (ADR-004).
badge_features, allowed_ticket_types and tags now report added and removed ids through SponsorSummitRegistrationPromoCodeAuditLogFormatter instead of being dropped (ADR-004).
romanetar
force-pushed
the
fix/audit-m2m-promo-codes
branch
from
November 10, 2026 13:10
4769c2b to
5dfcdde
Compare
|
📘 OpenAPI / Swagger preview ➡️ https://OpenStackweb.github.io/summit-api/openapi/pr-670/ This page is automatically updated on each push to this PR. |
1 similar comment
|
📘 OpenAPI / Swagger preview ➡️ https://OpenStackweb.github.io/summit-api/openapi/pr-670/ This page is automatically updated on each push to this PR. |
romanetar
marked this pull request as ready for review
November 10, 2026 13:15
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ref: https://app.clickup.com/t/9014802374/86bc72z5c
Summary
Part of a stack of 5 PRs that make every configured audit formatter handle many-to-many collection changes (ADR-004). Without a case for
EVENT_COLLECTION_MANYTOMANY_UPDATE/DELETE, a configured formatter returns null andAuditLogOtlpStrategydrops the entry, so attaching or detaching items left no audit trail.Covers the shared SummitRegistrationPromoCode collections (badge_features, allowed_ticket_types, tags) for PrePaidSummitRegistrationDiscountCode, SponsorSummitRegistrationDiscountCode and SponsorSummitRegistrationPromoCode.
One commit per formatter, each with its tests under
tests/OpenTelemetry/Formatters/(update with added and removed ids, delete with preloadeddeleted_ids, and null when there is no diff).Stack
Review in order; each PR is green on its own. The coverage guard test and the ADR-004 update land in the last PR (#671).
🤖 Generated with Claude Code