Repository navigation
Bump src/submodules/opslevel-go from e7cefed to 7304fbb - #435
dependabot[bot] wants to merge 3 commits into
Conversation
|
Dependency review: not safe to merge as-is
|
|
@dependabot rebase |
Bumps [src/submodules/opslevel-go](https://github.com/OpsLevel/opslevel-go) from `e7cefed` to `7304fbb`. - [Release notes](https://github.com/OpsLevel/opslevel-go/releases) - [Commits](OpsLevel/opslevel-go@e7cefed...7304fbb) --- updated-dependencies: - dependency-name: src/submodules/opslevel-go dependency-version: 7304fbb9539ae1a9496be2c6a01438ef35259cbc dependency-type: direct:production ... Signed-off-by: dependabot[bot] <support@github.com>
76dbedc to
a87bb7d
Compare
Co-authored-by: Cursor <cursoragent@cursor.com>
opslevel-go now requires golangci-lint v2 dependencies (goconst, nakedret, unconvert) that golangci-lint v1.64.8 no longer compiles against. Migrate .golangci.yml to the v2 format, keeping the v1 rule set by excluding the ST/QF checks that v2 folded into staticcheck. Co-authored-by: Cursor <cursoragent@cursor.com>
Farjaad
left a comment
There was a problem hiding this comment.
Dependency review (updated): safe to merge
This replaces my earlier "not safe to merge as-is" comment. I pushed two commits on top of Dependabot's submodule bump to fix the problems it caused. Inline comments explain each change.
What I pushed
7cad03ego mod tidy: syncssrc/go.mod/src/go.sumwith opslevel-go v2026.10.15. Without it,go build/go vetfail withupdates to go.mod needed.7173c0egolangci-lint v1.64.8 → v2.1.2: opslevel-go now requires newer goconst/nakedret/unconvert versions that v1.64.8 no longer compiles against, which broke the Tests job..golangci.ymlis migrated to the v2 format with the same rule set, and one new deprecation warning is suppressed incmd/property.go.
src/go.sum has no inline notes; it's the lockfile hashes that go mod tidy regenerated, and go mod verify passes.
Verification
- CI: Tests (gofumpt,
go vet, golangci-lint,./commontests) and CodeQL pass on7173c0e. - Local, Go 1.26.9: the same
task cisteps pass (golangci-lint: 0 issues), andgo mod verifypasses. - e2e suite passes against the API with a test-account token: Domain, Infrastructure, Service, System and Team happy paths (5/5, ~35s), with no cleanup errors.
- Not run: the
./cmdintegration tests (task test-integration), and the release workflow (dispatch-only).
Remaining caveats (not blocking)
- The CLI still imports and replaces
opslevel-go/v2025while the submodule declares/v2026. The directoryreplacemakes this work, butTaskfile.yml'sOPSLEVEL_GO_PKG(used bytask update-opslevel-go) and the imports should move to/v2026in a follow-up. - User-visible upstream change: filter predicates with
caseSensitiveonexists/matchesare now rejected by opslevel-go's validation. - The Tests path filter doesn't match submodule pointer changes, so future opslevel-go bumps won't run tests unless
go.modalso changes. - Because commits were pushed by hand, Dependabot will no longer rebase this PR automatically.
| github.com/nunnatsa/ginkgolinter v0.19.1 // indirect | ||
| github.com/olekukonko/tablewriter v0.0.5 // indirect | ||
| github.com/opslevel/moredefaults v0.0.0-20240529152742-17d1318a3c12 // indirect | ||
| github.com/opslevel/opslevel-go/v2026 v2026.10.15 // indirect |
There was a problem hiding this comment.
Added by go mod tidy. Only opslevel-go's own _test.go files import the /v2026 path, and tidy includes test dependencies of dependencies, so it resolves this from the module proxy. It isn't linked into the CLI: go list -deps ./... has no /v2026 packages, and the binary still builds from ./submodules/opslevel-go through the /v2025 replace. v2026.10.15 is also the same release as submodule commit 7304fbb. It goes away once we migrate imports to /v2026.
|
|
||
| tool ( | ||
| github.com/golangci/golangci-lint/cmd/golangci-lint | ||
| github.com/golangci/golangci-lint/v2/cmd/golangci-lint |
There was a problem hiding this comment.
Switched the tool from github.com/golangci/golangci-lint/cmd/golangci-lint (v1.64.8) to the /v2 module at v2.1.2, the same version opslevel-go uses.
Why: opslevel-go v2026.10.15 requires jgautheron/goconst v1.8.1, alexkohler/nakedret/v2 v2.0.6 and a newer golangci/unconvert. Go uses the highest required version of each, and golangci-lint v1.64.8 doesn't compile against them (not enough arguments in call to goconstAPI.Run, etc.), which is what failed the Tests job on 7cad03e. Go never picks a version below what a dependency requires, so upgrading the linter was the only fix. task lint / task fix still call go tool golangci-lint, so nothing else needed to change.
| github.com/golangci/go-printf-func-name v0.1.0 // indirect | ||
| github.com/golangci/gofmt v0.0.0-20250106114630-d62b90e6713d // indirect | ||
| github.com/golangci/golangci-lint v1.64.8 // indirect | ||
| github.com/golangci/golangci-lint/v2 v2.1.2 // indirect |
There was a problem hiding this comment.
The indirect requirement that comes with the golangci-lint v2 tool directive below. Most of the other go.mod/go.sum changes in this PR are linter and opslevel-go dependencies moving to the versions that v2 and opslevel-go v2026.10.15 require.
| - github.com/spf13/viper.Unmarshal | ||
| staticcheck: | ||
| checks: ["all", "-SA5001"] | ||
| version: "2" |
There was a problem hiding this comment.
Converted to the v2 config format with golangci-lint migrate. linters-settings became linters.settings, and the exclusions presets below are how v2 spells v1's default exclusion rules, so nothing new is excluded. run.timeout: 2m was dropped because v2 has no timeout by default; lint finishes in a few seconds here.
| - all | ||
| - -SA5001 | ||
| - -ST* | ||
| - -QF* |
There was a problem hiding this comment.
Two deliberate edits to what migrate generated:
- Order of
all/-SA5001:migratesorted these alphabetically, putting-SA5001beforeall. Staticcheck applies these entries in order, so that would have turned SA5001 back on. I restored the original order. -ST*and-QF*: v2 mergedstylecheck(ST) and the quick-fix checks (QF) into thestaticchecklinter, soallnow includes them. In v1 thestaticchecklinter only ran SA checks, and we never enabledstylecheck. Without these exclusions, v2 reports about 50 new findings: 25× ST1003 naming (teamId→teamID,JsonPrint→JSONPrint), 23× QF suggestions and 1× ST1005. Excluding them keeps lint enforcing the same rules as before. Enabling them would be a separate style cleanup.
| propertyId := args[1] | ||
|
|
||
| result, err := getClientGQL().GetProperty(ownerId, propertyId) | ||
| result, err := getClientGQL().GetProperty(ownerId, propertyId) //nolint:staticcheck // only resolves service owners; switching to Service/Team.GetProperty needs owner-type detection |
There was a problem hiding this comment.
The only new lint finding after the migration is a real SA1019, not a style check. opslevel-go v2026 deprecates Client.GetProperty in favor of Service.GetProperty / Team.GetProperty (added with team custom properties in OpsLevel/opslevel-go#609).
The deprecated method's query is unchanged (account.property(owner:, definition:)), so opslevel get property behaves exactly as before: service owners work, and team owners error from the API, which was already true. Switching to the new methods would mean working out whether the alias is a service or a team, which would add team support to the command. That's a feature for its own PR, so I suppressed the warning on this line instead.
Warning
Cooldown could not be applied because no publication date was available from the registry.
Bumps src/submodules/opslevel-go from
e7cefedto7304fbb.Commits
7304fbbCut Release 'v2026.10.15'269d20fBump github.com/go-playground/validator/v10 from 10.30.4 to 10.30.5 (#648)ce0e078Fix GO-2026-6612: bump golang.org/x/net to v0.60.0 and Go toolchain to 1.26.9...8614cfdBump github.com/relvacode/iso8601 from 1.8.1 to 1.8.2 (#650)4be688bBump github.com/relvacode/iso8601 from 1.8.0 to 1.8.1 (#649)3382deaBump github.com/go-playground/validator/v10 from 10.30.3 to 10.30.4 (#646)c6ed6faCut Release 'v2026.9.7'7872a54Add ListTeamsIncludingProperties for batched team metadata reads (#643)1967195Bump github.com/rs/zerolog from 1.34.0 to 1.35.1 (#635)cc98577Bump github.com/stretchr/testify from 1.11.1 to 1.12.1 (#636)