Repository navigation
Bump src/submodules/opslevel-go from e7cefed to 7304fbb
#435
+215
−160
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,16 +1,38 @@ | ||
| version: "2" | ||
| linters: | ||
| settings: | ||
| errcheck: | ||
| exclude-functions: | ||
| - (*encoding/csv.Writer).Write | ||
| - (*github.com/spf13/cobra.Command).MarkFlagRequired | ||
| - (*github.com/spf13/pflag.PFlagSet).GetString | ||
| - (*os.File).WriteString | ||
| - github.com/spf13/viper.BindEnv | ||
| - github.com/spf13/viper.BindPFlags | ||
| - github.com/spf13/viper.ReadConfig | ||
| - github.com/spf13/viper.ReadInConfig | ||
| - github.com/spf13/viper.Unmarshal | ||
| staticcheck: | ||
| checks: | ||
| - all | ||
| - -SA5001 | ||
| - -ST* | ||
| - -QF* | ||
|
Comment on lines
+17
to
+20
Contributor
There was a problem hiding this comment. Two deliberate edits to what
|
||
| exclusions: | ||
| generated: lax | ||
| presets: | ||
| - comments | ||
| - common-false-positives | ||
| - legacy | ||
| - std-error-handling | ||
| paths: | ||
| - third_party$ | ||
| - builtin$ | ||
| - examples$ | ||
| formatters: | ||
| exclusions: | ||
| generated: lax | ||
| paths: | ||
| - third_party$ | ||
| - builtin$ | ||
| - examples$ | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -54,7 +54,7 @@ var getPropertyCmd = &cobra.Command{ | |
| ownerId := args[0] | ||
| propertyId := args[1] | ||
|
|
||
| result, err := getClientGQL().GetProperty(ownerId, propertyId) //nolint:staticcheck // only resolves service owners; switching to Service/Team.GetProperty needs owner-type detection | ||
|
Contributor
There was a problem hiding this comment. The only new lint finding after the migration is a real SA1019, not a style check. opslevel-go v2026 deprecates The deprecated method's query is unchanged ( |
||
| cobra.CheckErr(err) | ||
| if result.Definition.Id == "" && result.Owner.Id() == "" { | ||
| err = fmt.Errorf("property '%s' on entity '%s' not found\n", propertyId, ownerId) | ||
|
|
||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Converted to the v2 config format with
golangci-lint migrate.linters-settingsbecamelinters.settings, and theexclusionspresets below are how v2 spells v1's default exclusion rules, so nothing new is excluded.run.timeout: 2mwas dropped because v2 has no timeout by default; lint finishes in a few seconds here.