Repository navigation
v2: don't treat time as a parameter in lint - #588
Merged
Merged
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #588 +/- ##
==========================================
+ Coverage 79.71% 79.73% +0.01%
==========================================
Files 70 70
Lines 8315 8318 +3
Branches 1506 1508 +2
==========================================
+ Hits 6628 6632 +4
+ Misses 1198 1197 -1
Partials 489 489 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This was referenced Nov 16, 2026
dweindl
force-pushed
the
fix_586_time
branch
from
November 16, 2026 18:14
dda5ef9 to
33c2109
Compare
`time` in condition target values, and in observable or noise formulas of PySB/BNGL models, was reported as a missing parameter by `CheckAllParametersPresentInParameterTable`. Exclude `TIME_SYMBOL` in `get_required_parameters_for_parameter_table`, `get_valid_parameters_for_parameter_table`, and `Problem.get_output_parameters`. A parameter table entry `time` (a reserved keyword) is now reported as extraneous. Fixes PEtab-dev#586. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
dweindl
force-pushed
the
fix_586_time
branch
from
November 16, 2026 19:22
33c2109 to
32f3332
Compare
dweindl
marked this pull request as ready for review
November 16, 2026 19:30
dilpath
approved these changes
Nov 16, 2026
dweindl
added a commit
to dweindl/libpetab-python
that referenced
this pull request
Nov 17, 2026
Every pull request added its changelog entry at the same place in `CHANGELOG.md`, so concurrent pull requests conflicted with each other. Now, each pull request adds its entry as a separate file `changelog.d/+<name>.<type>.md` (see `changelog.d/README.md`). At release time, `towncrier build --version X.Y.Z` collects them into `CHANGELOG.md`. The unreleased 0.11.0 entry is moved to `changelog.d/`, and entries are added for PEtab-dev#583, PEtab-dev#584, PEtab-dev#588, PEtab-dev#590, PEtab-dev#592 and PEtab-dev#595, which did not add one. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
dweindl
added a commit
to dweindl/libpetab-python
that referenced
this pull request
Nov 17, 2026
Every pull request added its changelog entry at the same place in `CHANGELOG.md`, so concurrent pull requests conflicted with each other. Now, each pull request adds its entry as a separate file `changelog.d/+<name>.<type>.md` (see `changelog.d/README.md`). At release time, `towncrier build --version X.Y.Z` collects them into `CHANGELOG.md`. The unreleased 0.11.0 entry is moved to `changelog.d/`, and entries are added for PEtab-dev#583, PEtab-dev#584, PEtab-dev#588, PEtab-dev#590, PEtab-dev#592 and PEtab-dev#595, which did not add one. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
dweindl
added a commit
to dweindl/libpetab-python
that referenced
this pull request
Nov 17, 2026
Every pull request added its changelog entry at the same place in `CHANGELOG.md`, so concurrent pull requests conflicted with each other. Now, each pull request adds its entry as a separate file `changelog.d/+<name>.<type>.md` (see `changelog.d/README.md`). At release time, `towncrier build --version X.Y.Z` collects them into `CHANGELOG.md`. The unreleased 0.11.0 entry is moved to `changelog.d/`, and entries are added for PEtab-dev#583, PEtab-dev#584, PEtab-dev#588, PEtab-dev#590, PEtab-dev#592 and PEtab-dev#595, which did not add one. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
dweindl
added a commit
to dweindl/libpetab-python
that referenced
this pull request
Nov 17, 2026
…v#600) Every pull request added its changelog entry at the same place in `CHANGELOG.md`, so concurrent pull requests conflicted with each other. Now, each pull request adds its changelog entry as a separate file `changelog.d/+<name>.<type>.md` (see `changelog.d/README.md`). At release time, `towncrier build --version X.Y.Z` collects them into `CHANGELOG.md` and removes the fragments. The template in `changelog.d/template.md.j2` reproduces the existing format (`**Fixes**` etc., `* ` bullets with 2-space continuation lines). Entries are sorted alphabetically within each category; grouping them (e.g., by PEtab version or module) is done when compiling the release notes. The configuration is in `pyproject.toml`, and towncrier is added to the `test` dependency group. The release process in `doc/development.rst` is updated accordingly. Entries now link to the pull request only, without "by @user"; contributors can be credited in the release notes. The unreleased 0.11.0 entry (PEtab-dev#578) is moved to `changelog.d/`, and entries are added for PEtab-dev#583, PEtab-dev#584, PEtab-dev#588, PEtab-dev#590, PEtab-dev#592 and PEtab-dev#595, which did not add one. The behaviour changes from PEtab-dev#584 (top-level Boolean expressions are returned as `Piecewise`) and PEtab-dev#592 (stricter `PySBModel.pattern_from_string`) are listed as breaking changes. Open pull requests that edit `CHANGELOG.md` will need to move their entry to a fragment file. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
CheckAllParametersPresentInParameterTablereportedtimeas a missing parameter when it occurred in condition target values (any model type), or in observable/noise formulas with PySB or BNGL models (SBML models already allowed it there).TIME_SYMBOLis now excluded inget_required_parameters_for_parameter_table,get_valid_parameters_for_parameter_table, andProblem.get_output_parameters.Behaviour change: a parameter table entry
time(a reserved keyword in PEtab v2) is now reported as extraneous; previously it was silently accepted, which may have been used as a workaround for this bug.Fixes #586.
🤖 Generated with Claude Code