You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
fix(ci): remove duplicate e2e suite registration - #14928
The e2e-scoped scope self-test stops before selecting or running any suites because snap_image_literal_order occurs twice in _CODEGEN_SUITES. Remove the duplicate registration so the configured list agrees with the selector's deduplicated output. The suite remains selected once for codegen changes; no coverage is removed.
Changes
scripts/ci_e2e_scope.py: retain one registration of snap_image_literal_order.
Related issue
Refs #14838; discovered while investigating CI on #14919. No open PR already fixes this duplicate registration.
Test plan
Before the change, python3 scripts/ci_e2e_scope.py --self-test exits 1 at the codegen-source selection case.
After the change, python3 scripts/ci_e2e_scope.py --self-test exits 0.
Feed crates/perry-codegen/src/codegen/helpers.rs into the scope CLI: 51 unique mapped suites, exactly one snap_image_literal_order, each with its execution budget.
Feed crates/perry-runtime/src/tui/cell.rs into the scope CLI: no unrelated integration suite is selected.
git diff --check.
BASE_SHA=upstream/main CARGO_NET_OFFLINE=true SKIP_COMPILE_GATES=1 bash scripts/run_lint_gates.sh — the initial run has 18/142 failing commands; 2 CI-only arms skipped, compile tier explicitly skipped. A clean checkout at the same 2ea9a8be base has the same 17 failures except the parity-runner fixture. The unchanged parity-runner suite then passes all 52 tests on this branch when rerun separately. That fixture enforces a one-second subprocess deadline and showed varying additional timeout verdicts during concurrent build/gate work. No timeout or test code is changed to hide it. All other failing command names match the clean base; no full-lint pass is claimed.
Checklist
No workspace version bump or CHANGELOG.md edit.
One CI-only change; no crate/API change or changelog fragment required.
This removes a duplicate suite registration in the e2e scope script. Codegen changes still select the snap_image_literal_order suite once, so coverage is kept. No merge-blocking risk was found.
Pre-merge checks: 4
Check name
Status
Explanation
Title check
The title states the main change: removing a duplicate e2e suite registration in CI. The raw summary and objectives confirm that the only code change removes one duplicate snap_image_literal_order ent…
Linked Issues check
Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check
Check skipped because no linked issues were found for this pull request.
Description check
The description states the problem, the one-line change, the related issue (Refs #14838), and a detailed test plan with checked items. It follows the repository template's sections: Summary, Changes, …
Full details: Title check
Explanation
The title states the main change: removing a duplicate e2e suite registration in CI. The raw summary and objectives confirm that the only code change removes one duplicate snap_image_literal_order entry from _CODEGEN_SUITES in scripts/ci_e2e_scope.py. The title is specific, follows the fix(ci): prefix convention, and is concise.
Full details: Description check
Explanation
The description states the problem, the one-line change, the related issue (Refs #14838), and a detailed test plan with checked items. It follows the repository template's sections: Summary, Changes, Related issue, Test plan, and Checklist. It omits the template's optional Screenshots section, which is acceptable. The test plan includes a lint-gate item left unchecked with a long explanation of 18 of 142 failing commands. It does not claim full-lint success, so this is disclosed rather than hidden. The template's checkbox for building with cargo build --release and the workspace test command are not explicitly ticked, though the PR is CI-only.
Finishing Touches
Generate unit tests (beta)
Create a new PR
Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.
File: No configuration file from this repository applied
Commit: Unavailable
Layers: defaults
Review profile: CHILL
Plan: Advanced
Run ID: 637776eb-862d-4db5-a447-7ebf7db0630e
Commits
Reviewing files that changed from the base of the PR and between 2ea9a8b and 45a65a5.
Files selected for processing: 1
scripts/ci_e2e_scope.py
Files with no reviewable changes: 1
scripts/ci_e2e_scope.py
Included review availability: This review used your included allowance. Your plan provides up to 8 included reviews per hour; 7 remain after this review.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The
e2e-scopedscope self-test stops before selecting or running any suites becausesnap_image_literal_orderoccurs twice in_CODEGEN_SUITES. Remove the duplicate registration so the configured list agrees with the selector's deduplicated output. The suite remains selected once for codegen changes; no coverage is removed.Changes
scripts/ci_e2e_scope.py: retain one registration ofsnap_image_literal_order.Related issue
Refs #14838; discovered while investigating CI on #14919. No open PR already fixes this duplicate registration.
Test plan
python3 scripts/ci_e2e_scope.py --self-testexits 1 at the codegen-source selection case.python3 scripts/ci_e2e_scope.py --self-testexits 0.e2e-scopedCI job completes successfully.python3 scripts/ci_test_scope.py --self-testexits 0.crates/perry-codegen/src/codegen/helpers.rsinto the scope CLI: 51 unique mapped suites, exactly onesnap_image_literal_order, each with its execution budget.crates/perry-runtime/src/tui/cell.rsinto the scope CLI: no unrelated integration suite is selected.git diff --check.BASE_SHA=upstream/main CARGO_NET_OFFLINE=true SKIP_COMPILE_GATES=1 bash scripts/run_lint_gates.sh— the initial run has 18/142 failing commands; 2 CI-only arms skipped, compile tier explicitly skipped. A clean checkout at the same2ea9a8bebase has the same 17 failures except the parity-runner fixture. The unchanged parity-runner suite then passes all 52 tests on this branch when rerun separately. That fixture enforces a one-second subprocess deadline and showed varying additional timeout verdicts during concurrent build/gate work. No timeout or test code is changed to hide it. All other failing command names match the clean base; no full-lint pass is claimed.Checklist
CHANGELOG.mdedit.