Skip to content

fix(ci): remove duplicate e2e suite registration - #14928

Merged
TheHypnoo merged 1 commit into
PerryTS:mainfrom
wsafight:fix/ci-e2e-scope-map
Nov 18, 2026
Merged

TheHypnoo merged 1 commit into
PerryTS:mainfrom
wsafight:fix/ci-e2e-scope-map

Conversation

@wsafight

@wsafight wsafight commented Nov 17, 2026 •

Copy link
Copy Markdown
Contributor

Summary

The e2e-scoped scope self-test stops before selecting or running any suites because snap_image_literal_order occurs twice in _CODEGEN_SUITES. Remove the duplicate registration so the configured list agrees with the selector's deduplicated output. The suite remains selected once for codegen changes; no coverage is removed.

Changes

  • scripts/ci_e2e_scope.py: retain one registration of snap_image_literal_order.

Related issue

Refs #14838; discovered while investigating CI on #14919. No open PR already fixes this duplicate registration.

Test plan

  • Before the change, python3 scripts/ci_e2e_scope.py --self-test exits 1 at the codegen-source selection case.
  • After the change, python3 scripts/ci_e2e_scope.py --self-test exits 0.
  • Upstream e2e-scoped CI job completes successfully.
  • python3 scripts/ci_test_scope.py --self-test exits 0.
  • Feed crates/perry-codegen/src/codegen/helpers.rs into the scope CLI: 51 unique mapped suites, exactly one snap_image_literal_order, each with its execution budget.
  • Feed crates/perry-runtime/src/tui/cell.rs into the scope CLI: no unrelated integration suite is selected.
  • git diff --check.
  • BASE_SHA=upstream/main CARGO_NET_OFFLINE=true SKIP_COMPILE_GATES=1 bash scripts/run_lint_gates.sh — the initial run has 18/142 failing commands; 2 CI-only arms skipped, compile tier explicitly skipped. A clean checkout at the same 2ea9a8be base has the same 17 failures except the parity-runner fixture. The unchanged parity-runner suite then passes all 52 tests on this branch when rerun separately. That fixture enforces a one-second subprocess deadline and showed varying additional timeout verdicts during concurrent build/gate work. No timeout or test code is changed to hide it. All other failing command names match the clean base; no full-lint pass is claimed.

Checklist

  • No workspace version bump or CHANGELOG.md edit.
  • One CI-only change; no crate/API change or changelog fragment required.

@coderabbitai

coderabbitai Bot commented Nov 17, 2026 •

Copy link
Copy Markdown

Explain Change →

No actionable comments were generated in the recent review.

Walkthrough

The codegen source mapping no longer selects snap_image_literal_order when paths under crates/perry-codegen/src/ change.

Changes: Codegen E2E suite scope

Layer / File(s) Summary
Update codegen suite mapping
scripts/ci_e2e_scope.py
_CODEGEN_SUITES no longer includes snap_image_literal_order.

Estimated code review effort: 1 (Trivial) | ~3 minutes

Change: Bug fix

Suggested reviewers: raliclo

Merge Risk: Minimal · up to 45a65

This removes a duplicate suite registration in the e2e scope script. Codegen changes still select the snap_image_literal_order suite once, so coverage is kept. No merge-blocking risk was found.

Pre-merge checks: Passed 4

Check name Status Explanation
Title check Passed The title states the main change: removing a duplicate e2e suite registration in CI. The raw summary and objectives confirm that the only code change removes one duplicate snap_image_literal_order ent…
Linked Issues check Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check Passed Check skipped because no linked issues were found for this pull request.
Description check Passed The description states the problem, the one-line change, the related issue (Refs #14838), and a detailed test plan with checked items. It follows the repository template's sections: Summary, Changes, …
Full details: Title check

Explanation

The title states the main change: removing a duplicate e2e suite registration in CI. The raw summary and objectives confirm that the only code change removes one duplicate snap_image_literal_order entry from _CODEGEN_SUITES in scripts/ci_e2e_scope.py. The title is specific, follows the fix(ci): prefix convention, and is concise.

Full details: Description check

Explanation

The description states the problem, the one-line change, the related issue (Refs #14838), and a detailed test plan with checked items. It follows the repository template's sections: Summary, Changes, Related issue, Test plan, and Checklist. It omits the template's optional Screenshots section, which is acceptable. The test plan includes a lint-gate item left unchecked with a long explanation of 18 of 142 failing commands. It does not claim full-lint success, so this is disclosed rather than hidden. The template's checkbox for building with cargo build --release and the workspace test command are not explicitly ticked, though the PR is CI-only.

Finishing Touches

Generate unit tests (beta)

  • Create a new PR
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

Share

Recent review info

Run configuration

  • Source mode: Auto
  • Repository: Unavailable
  • Branch: Unavailable
  • File: No configuration file from this repository applied
  • Commit: Unavailable
  • Layers: defaults
  • Review profile: CHILL
  • Plan: Advanced
  • Run ID: 637776eb-862d-4db5-a447-7ebf7db0630e
Commits

Reviewing files that changed from the base of the PR and between 2ea9a8b and 45a65a5.

Files selected for processing: 1

  • scripts/ci_e2e_scope.py
Files with no reviewable changes: 1

  • scripts/ci_e2e_scope.py

Included review availability: This review used your included allowance. Your plan provides up to 8 included reviews per hour; 7 remain after this review.

@wsafight
wsafight marked this pull request as ready for review November 17, 2026 16:02
@TheHypnoo TheHypnoo added area:tooling-ci CLI driver, scripts, CI, release effort:S Hours: one local fix impact:high Common programs break, platform or CI blocked type:chore Refactor, CI, docs, cleanup labels Nov 18, 2026
@TheHypnoo
TheHypnoo merged commit e11a18c into PerryTS:main Nov 18, 2026
236 of 404 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area:tooling-ci CLI driver, scripts, CI, release effort:S Hours: one local fix impact:high Common programs break, platform or CI blocked type:chore Refactor, CI, docs, cleanup

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants