Repository navigation
README: the Masterflex and ThermoShake examples use their v1 drivers - #1615
Closed
sriramdevadas wants to merge 1 commit into
Closed
sriramdevadas wants to merge 1 commit into
sriramdevadas wants to merge 1 commit into
Conversation
The pump example opens a `Masterflex` on a serial port and runs it at 100 rpm for 30 s with `run_continuously` and `halt`. The heater shaker example opens an `InhecoTECControlBox` and sets the ThermoShake at index 1 to 37 °C.
Member
|
thanks for the PR! there are actually many problems in the readme with the transition to v1. i think we should delete these examples for now since having them for every device is unwieldy. feel free to make a PR for that if you like :) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The Problem
Two
README.mdexamples fail at import onmain:from pylabrobot.pumps.cole_parmer.masterflex import MasterflexraisesModuleNotFoundError: No module named 'pylabrobot.pumps.cole_parmer'.from pylabrobot.heating_shaking import HeaterShaker, InhecoThermoShakeBackendraisesImportError: cannot import name 'InhecoThermoShakeBackend'.PR Content
pylabrobot.cole_parmer.Masterflex, withrun_continuously(speed=100), a 30 s wait andhalt(), the run, wait and halt thatPump.run_for_durationdescribes.InhecoTECControlBoxandinheco_thermoshake(..., index=1), set up as in the ThermoShake hello-world notebook, thenset_temperature(37).Open PR #1524 also edits these two blocks (it wraps them in
async with) and leaves their imports as they are, so the second of the two to merge will have a small conflict inREADME.md.Tests: docs only; no test reads
README.md. Every README import resolves on this branch, and with the serial port and the HID device replaced by recorders the examples sendS+100G0,Hafter the wait,1STT370and1ATE1. The Unit Tests workflow passes on my fork on this commit (run).🤖 Generated with Claude Code