Repository navigation
fix(ui): rules use the workbench border colour through QueryaDivider - #1457
Merged
Merged
Conversation
Material's Divider reads the Material dividerColor and is near-black in the light theme (connection forms). QueryaDivider / QueryaDivider.vertical draw workbench.borderSubtle; the 85 Divider / VerticalDivider calls in lib use it and a guard test rejects the raw ones. Refs #1443
github-actions
Bot
added
bug
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1443.
QueryaDividerandQueryaDivider.verticalin the kit:workbench.borderSubtleby default (workbenchOrDefault, works without a theme scope), optionalcolor,thickness,indent,endIndent.material.Divider/material.VerticalDividerand the shadcnDivider/VerticalDividercalls inlib/use it (about 85 call sites in 40 files); the connection forms no longer draw near-black rules in the light theme.test/guards/no_raw_dividers_test.dart: no rawDivider(/VerticalDivider(outside the kit.docs/ui-kit.mdmigration table updated.The unprefixed
Dividercalls were shadcn's, so this is also one item of #1365.