Skip to content

fix(ui): rules use the workbench border colour through QueryaDivider #1457

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ZhuchkaTriplesix merged 1 commit into from
Oct 11, 2026
Merged

fix(ui): rules use the workbench border colour through QueryaDivider #1457

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions docs/ui-kit.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -218,6 +218,7 @@ Canonical labels and roles from the review:
| shadcn `normal` / `small` size | `lg` (dialogs, forms) / `sm` or `md` (toolbars, by row) |
| `QueryaActionButton` | `QueryaButton` `secondary`, `md` |
| `QueryaActionMenu` trigger | `QueryaMenuButton` |
| `Divider` / `VerticalDivider` (Material or shadcn) | `QueryaDivider` / `QueryaDivider.vertical` (workbench `borderSubtle`; a guard rejects the raw ones) |
| split "Execute" assembled by hand | `QueryaSplitButton` |
| shadcn / material `IconButton`, private `_TreeIconButton` | `QueryaIconButton` (with tooltip) |
| `InkWell` / `GestureDetector` around an icon or text | `QueryaButton` or `QueryaIconButton` |
Expand Down
2 changes: 1 addition & 1 deletion lib/features/command_palette/command_palette_dialog.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -201,7 +201,7 @@ class _CommandPaletteDialogState extends State<CommandPaletteDialog> {
},
),
),
const Divider(),
const QueryaDivider(),
Expanded(
child: _objectPrefix
? _PrefixHint(query: _objectQuery, onOpen: _openQuickSwitcher)
Expand Down
2 changes: 1 addition & 1 deletion lib/features/command_palette/quick_switcher_dialog.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -208,7 +208,7 @@ class _QuickSwitcherDialogState extends State<QuickSwitcherDialog> {
},
),
),
const Divider(),
const QueryaDivider(),
Expanded(child: _body(theme.colorScheme, hits, selectedIndex)),
],
),
Expand Down
2 changes: 1 addition & 1 deletion lib/features/connections/connections_panel.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1273,7 +1273,7 @@ class ConnectionsPanelState extends State<ConnectionsPanel> {
),
),
),
Divider(
QueryaDivider(
height: 1,
color: theme.colorScheme.border.withValues(alpha: 0.22),
),
Expand Down
2 changes: 1 addition & 1 deletion lib/features/connections/driver_manager_dialog.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -116,7 +116,7 @@ class _DriverManagerDialogContent extends material.StatelessWidget {
shrinkWrap: true,
padding: const material.EdgeInsets.symmetric(vertical: 8),
itemCount: drivers.length,
separatorBuilder: (_, __) => material.Divider(
separatorBuilder: (_, __) => QueryaDivider(
height: 1,
color: theme.border.withValues(alpha: 0.3),
),
Expand Down
2 changes: 1 addition & 1 deletion lib/features/connections/sqlite_connection_form.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -318,7 +318,7 @@ class _SqliteConnectionFormContentState
),
),
),
const material.Divider(height: 1),
const QueryaDivider(height: 1),
// Test result banner
if (_testResult != null)
material.Padding(
Expand Down
2 changes: 1 addition & 1 deletion lib/features/extensions/extension_workspace_home.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -130,7 +130,7 @@ class _ExtensionWorkspaceHomeState
],
),
),
const Divider(height: 1),
const QueryaDivider(height: 1),
Expanded(
child: QueryaCrossFadeStack(
index: _tab,
Expand Down
2 changes: 1 addition & 1 deletion lib/features/extensions/presentation/pages/extension_manager_dialog.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -254,7 +254,7 @@ class _ExtensionManagerContentState
onSelected: (index) => setState(() => _tabIndex = index),
),
),
material.Divider(height: 1, color: theme.border),
QueryaDivider(height: 1, color: theme.border),
material.Expanded(
child: QueryaCrossFadeStack(
index: _tabIndex,
Expand Down
2 changes: 1 addition & 1 deletion lib/features/main_screen/main_screen.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1118,7 +1118,7 @@ class _MainScreenState extends State<MainScreen> {
);
},
),
Divider(
QueryaDivider(
height: 1,
color: wb.borderSubtle.withValues(alpha: 0.22)),
Expanded(
Expand Down
6 changes: 3 additions & 3 deletions lib/features/mongodb/mongo_add_document_dialog.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -120,7 +120,7 @@ class _MongoAddDocumentDialogState extends material.State<MongoAddDocumentDialog
],
),
),
const material.Divider(height: 1),
const QueryaDivider(height: 1),
if (_error != null) ...[
material.Container(
padding: const material.EdgeInsets.symmetric(
Expand All @@ -141,7 +141,7 @@ class _MongoAddDocumentDialogState extends material.State<MongoAddDocumentDialog
],
),
),
const material.Divider(height: 1),
const QueryaDivider(height: 1),
],
material.Padding(
padding: const material.EdgeInsets.all(24),
Expand Down Expand Up @@ -172,7 +172,7 @@ class _MongoAddDocumentDialogState extends material.State<MongoAddDocumentDialog
],
),
),
const material.Divider(height: 1),
const QueryaDivider(height: 1),
material.Container(
padding: const material.EdgeInsets.symmetric(
horizontal: 24, vertical: 16),
Expand Down
10 changes: 5 additions & 5 deletions lib/features/mongodb/mongo_aggregation_workspace.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -214,7 +214,7 @@ class _MongoAggregationWorkspaceState
children: [
// Top action bar
_buildActionBar(cs),
const Divider(height: 1),
const QueryaDivider(height: 1),
// Main content: responsive layout
material.Expanded(
child: material.LayoutBuilder(
Expand All @@ -228,7 +228,7 @@ class _MongoAggregationWorkspaceState
width: (constraints.maxWidth * 0.45).clamp(380.0, 560.0),
child: _buildStagesPane(cs),
),
const VerticalDivider(width: 1),
const QueryaDivider.vertical(width: 1),
// Right pane: Results
material.Expanded(
child: _buildResultsPane(cs),
Expand All @@ -243,7 +243,7 @@ class _MongoAggregationWorkspaceState
flex: 5,
child: _buildStagesPane(cs),
),
const Divider(height: 1),
const QueryaDivider(height: 1),
material.Expanded(
flex: 5,
child: _buildResultsPane(cs),
Expand Down Expand Up @@ -344,7 +344,7 @@ class _MongoAggregationWorkspaceState
],
),
),
const Divider(height: 1),
const QueryaDivider(height: 1),
material.Expanded(
child: material.ListView.separated(
padding: const material.EdgeInsets.all(12),
Expand Down Expand Up @@ -440,7 +440,7 @@ class _MongoAggregationWorkspaceState
],
),
),
const Divider(height: 1),
const QueryaDivider(height: 1),
// Error banner if any
if (_executionError != null)
material.Container(
Expand Down
2 changes: 1 addition & 1 deletion lib/features/mongodb/mongo_collections_view.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -361,7 +361,7 @@ class _MongoCollectionsViewState extends material.State<MongoCollectionsView> {
: material.ListView.separated(
cacheExtent: 400,
itemCount: _collections.length,
separatorBuilder: (_, __) => Divider(
separatorBuilder: (_, __) => QueryaDivider(
height: 1,
color: cs.border.withValues(alpha: 0.15),
),
Expand Down
2 changes: 1 addition & 1 deletion lib/features/mongodb/mongo_create_index_dialog.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -288,7 +288,7 @@ class _MongoCreateIndexDialogState
),
),
const Gap(16),
const Divider(height: 1),
const QueryaDivider(height: 1),
const Gap(12),
// Options
const Text('Index Options').semiBold().small(),
Expand Down
4 changes: 2 additions & 2 deletions lib/features/mongodb/mongo_database_dialog.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -71,7 +71,7 @@ class _CreateMongoDBDialogContentState
],
),
),
const material.Divider(height: 1),
const QueryaDivider(height: 1),
material.Padding(
padding: const material.EdgeInsets.all(24),
child: material.Column(
Expand All @@ -86,7 +86,7 @@ class _CreateMongoDBDialogContentState
],
),
),
const material.Divider(height: 1),
const QueryaDivider(height: 1),
material.Container(
padding: const material.EdgeInsets.symmetric(
horizontal: 24, vertical: 16),
Expand Down
2 changes: 1 addition & 1 deletion lib/features/mongodb/mongo_databases_view.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -340,7 +340,7 @@ class _MongoDatabasesViewState extends State<MongoDatabasesView> {
// Database rows
for (var i = 0; i < _databases.length; i++) ...[
if (i > 0)
Divider(height: 1, color: cs.border.withValues(alpha: 0.15)),
QueryaDivider(height: 1, color: cs.border.withValues(alpha: 0.15)),
_DatabaseRow(
database: _databases[i],
colorScheme: cs,
Expand Down
3 changes: 2 additions & 1 deletion lib/features/mongodb/mongo_document_tree_view.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,6 +9,7 @@ import 'package:querya_desktop/shared/widgets/app_toast.dart';
import 'package:shadcn_flutter/shadcn_flutter.dart';
import 'package:querya_desktop/core/ui/querya_control_tokens.dart';
import 'package:querya_desktop/shared/widgets/querya_button.dart';
import 'package:querya_desktop/shared/widgets/querya_divider.dart';

/// Appends a key or list index to a JavaScript / JSON Path expression.
///
Expand Down Expand Up @@ -341,7 +342,7 @@ class _MongoDocumentTreeViewState extends State<MongoDocumentTreeView> {
),
// Expanded Tree content
if (isExpanded) ...[
material.Divider(
QueryaDivider(
height: 1,
color: cs.border.withValues(alpha: 0.2),
),
Expand Down
4 changes: 2 additions & 2 deletions lib/features/mongodb/mongo_documents_view.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -383,7 +383,7 @@ class _MongoDocumentsViewState extends material.State<MongoDocumentsView> {
children: [
// Filter bar
_buildFilterBar(cs),
const Divider(height: 1),
const QueryaDivider(height: 1),
// Error banner
if (_error != null) _buildErrorBanner(cs),
// Document content (mode-dependent)
Expand Down Expand Up @@ -877,7 +877,7 @@ class MongoFieldList extends StatelessWidget {
);
}

Widget _buildDivider() => material.Divider(
Widget _buildDivider() => QueryaDivider(
height: 1,
color: colorScheme.border.withValues(alpha: 0.2),
);
Expand Down
2 changes: 1 addition & 1 deletion lib/features/mongodb/mongo_explorer_view.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -359,7 +359,7 @@ class _MongoExplorerViewState extends material.State<MongoExplorerView> {
onRefresh: () => setState(() => _refreshToken++),
onStats: () => setState(() => _showStats = !_showStats),
),
const Divider(height: 1),
const QueryaDivider(height: 1),
// Content with fluid cross-fade morph between explorer and stats
material.Expanded(
child: QueryaSwitchingBody(
Expand Down
2 changes: 1 addition & 1 deletion lib/features/mongodb/mongo_indexes_view.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -196,7 +196,7 @@ class _MongoIndexesViewState extends material.State<MongoIndexesView> {
children: [
// Header action bar
_buildHeader(cs),
const Divider(height: 1),
const QueryaDivider(height: 1),
// Error banner
if (_error != null)
material.Container(
Expand Down
10 changes: 5 additions & 5 deletions lib/features/mongodb/mongo_query_workspace.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -232,7 +232,7 @@ class _MongoQueryWorkspaceState extends material.State<MongoQueryWorkspace> {
: material.ListView.separated(
shrinkWrap: true,
itemCount: history.length,
separatorBuilder: (_, __) => const Divider(height: 1),
separatorBuilder: (_, __) => const QueryaDivider(height: 1),
itemBuilder: (context, i) {
final item = history[i];
return material.ListTile(
Expand Down Expand Up @@ -304,10 +304,10 @@ class _MongoQueryWorkspaceState extends material.State<MongoQueryWorkspace> {
children: [
// Top action bar
_buildTopBar(cs),
const Divider(height: 1),
const QueryaDivider(height: 1),
// Tab strip
_buildTabStrip(cs),
const Divider(height: 1),
const QueryaDivider(height: 1),
// Main content split
material.Expanded(
child: material.Column(
Expand All @@ -326,10 +326,10 @@ class _MongoQueryWorkspaceState extends material.State<MongoQueryWorkspace> {
),
),
),
const Divider(height: 1),
const QueryaDivider(height: 1),
// Result bar & timing stats
_buildResultBar(cs, tab),
const Divider(height: 1),
const QueryaDivider(height: 1),
// Results view (bottom half)
material.Expanded(
flex: 6,
Expand Down
2 changes: 1 addition & 1 deletion lib/features/mongodb/mongo_stats_view.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -222,7 +222,7 @@ class _MongoStatsViewState extends material.State<MongoStatsView> {
padding: const material.EdgeInsets.fromLTRB(24, 20, 24, 16),
child: _header(context),
),
const Divider(height: 1),
const QueryaDivider(height: 1),
material.Expanded(
child: _buildBody(context, cs),
),
Expand Down
4 changes: 2 additions & 2 deletions lib/features/mongodb/mongodb_connection_form.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -409,7 +409,7 @@ class _MongoConnectionFormContentState
],
),
),
const material.Divider(height: 1),
const QueryaDivider(height: 1),
material.Expanded(
child: material.FocusTraversalGroup(
policy: material.WidgetOrderTraversalPolicy(),
Expand Down Expand Up @@ -579,7 +579,7 @@ class _MongoConnectionFormContentState
),
),
),
const material.Divider(height: 1),
const QueryaDivider(height: 1),
if (_testResult != null)
material.Padding(
padding: const material.EdgeInsets.fromLTRB(24, 8, 16, 8),
Expand Down
4 changes: 2 additions & 2 deletions lib/features/mysql/mysql_connection_form.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -383,7 +383,7 @@ class _MysqlConnectionFormContentState
],
),
),
const material.Divider(height: 1),
const QueryaDivider(height: 1),
material.Expanded(
child: material.FocusTraversalGroup(
policy: material.WidgetOrderTraversalPolicy(),
Expand Down Expand Up @@ -484,7 +484,7 @@ class _MysqlConnectionFormContentState
),
),
),
const material.Divider(height: 1),
const QueryaDivider(height: 1),
if (_testResult != null)
material.Padding(
padding: const material.EdgeInsets.fromLTRB(24, 8, 16, 8),
Expand Down
2 changes: 1 addition & 1 deletion lib/features/mysql/mysql_stats_view.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -604,7 +604,7 @@ class _MysqlStatsViewState extends material.State<MysqlStatsView> {
],
),
),
material.Divider(height: 1, color: cs.border.withValues(alpha: 0.3)),
QueryaDivider(height: 1, color: cs.border.withValues(alpha: 0.3)),
for (final db in databases)
material.Padding(
padding: const material.EdgeInsets.symmetric(vertical: 5),
Expand Down
2 changes: 1 addition & 1 deletion lib/features/mysql/mysql_workspace_home.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -130,7 +130,7 @@ class _MysqlWorkspaceHomeState extends material.State<MysqlWorkspaceHome> {
],
),
),
const Divider(height: 1),
const QueryaDivider(height: 1),
Expanded(
child: QueryaCrossFadeStack(
index: _tab,
Expand Down
10 changes: 5 additions & 5 deletions lib/features/onboarding/welcome_tour_dialog.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -674,15 +674,15 @@ class _HotkeysMatrixSlideView extends StatelessWidget {
child: material.Column(
children: [
_hotkeyRow(context, 'Run Query / Script', [cmdCtrl, 'Enter'], wb),
const material.Divider(height: 10),
const QueryaDivider(height: 10),
_hotkeyRow(context, 'New Connection', [cmdCtrl, 'N'], wb),
const material.Divider(height: 10),
const QueryaDivider(height: 10),
_hotkeyRow(context, 'Toggle Sidebar', [cmdCtrl, 'B'], wb),
const material.Divider(height: 10),
const QueryaDivider(height: 10),
_hotkeyRow(context, 'Compound Filter Bar', [cmdCtrl, 'F'], wb),
const material.Divider(height: 10),
const QueryaDivider(height: 10),
_hotkeyRow(context, 'Copy Selection (TSV)', [cmdCtrl, 'C'], wb),
const material.Divider(height: 10),
const QueryaDivider(height: 10),
_hotkeyRow(context, 'Open Guide / Tour', ['F1'], wb),
],
),
Expand Down
2 changes: 1 addition & 1 deletion lib/features/postgresql/postgres_stats_view.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -566,7 +566,7 @@ class _PostgresStatsViewState extends material.State<PostgresStatsView> {
],
),
),
material.Divider(height: 1, color: cs.border.withValues(alpha: 0.3)),
QueryaDivider(height: 1, color: cs.border.withValues(alpha: 0.3)),
for (final db in databases)
material.Padding(
padding: const material.EdgeInsets.symmetric(vertical: 5),
Expand Down
4 changes: 2 additions & 2 deletions lib/features/postgresql/postgres_table_privileges_dialog.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -133,9 +133,9 @@ class _PrivilegesDialogBodyState extends material.State<_PrivilegesDialogBody> {
],
),
),
const material.Divider(height: 1),
const QueryaDivider(height: 1),
material.Expanded(child: _buildListArea(theme)),
const material.Divider(height: 1),
const QueryaDivider(height: 1),
material.Padding(
padding: const material.EdgeInsets.all(12),
child: material.Row(
Expand Down
2 changes: 1 addition & 1 deletion lib/features/postgresql/postgres_workspace_home.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -145,7 +145,7 @@ class _PostgresWorkspaceHomeState
],
),
),
const Divider(height: 1),
const QueryaDivider(height: 1),
Expanded(
child: QueryaCrossFadeStack(
index: _tab,
Expand Down
Loading
Loading