Repository navigation
ux(sql-workspace): toolbar and tab strip as one system (#1558, stage 1, part 1) - #1727
Merged
Merged
Conversation
…s own icon, labels collapse one control at a time, the tab strip uses workbench tokens (#1558)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Refs #1558 (stage 1, first PR). Stage 1 continues with the editor and results surfaces; stage 2 (fewer rows) is separate.
What a screenshot of current
dev(Demo Playground, 1028 px window, sidebar open, dark theme) showed, and what this changes:account_tree_outlined). Explain now hasmanage_search_rounded(a magnifier over lines: the plan); Diagram keeps the tree.Auto-commitpill next to 36 px buttons, and the same state again in the Session label. The badge is now shown only for what is not the default (Transaction open,Manual commit); auto-commit is named by the Session menu (label when wide, tooltipSession: auto-commitwhen narrow).compactwas decided at 900 px of toolbar width, which a 1028 px window with the sidebar open never reaches. The row now collapses one control at a time: above 900 px all labels; below, Explain and Session are icons andExecute (F5)keeps its label; below 620 px the run button is an icon too. At 1028 px with the sidebar open the run button readsExecute (F5)(checked on the running app).colorScheme.card/.border) next to a toolbar on workbench tokens: it now usesSqlEditorChrome.sqlToolbarDecoration, the same surface and hairline as the toolbar under it.Tests:
sql_workspace_chrome_guards_test(nocolorSchemeand no rawColor(0xin the tab strip, toolbar and editor chrome; Explain and Diagram icons differ; tab strip and toolbar share the decoration); the label test is rewritten for the three widths (900+, 800, 560); the transaction e2e test reads the Session tooltip where it read the pill. Workspace and e2e suites pass locally (586).Not in this PR: the editor's accent glow and the results frame (stage 1, next), the duplicated counts and the staged-changes row (stage 1 / 2), the layout work of stage 2. The before/after screenshot pair for dark and light themes the issue asks for comes with the end of stage 1.