Repository navigation
conditional_python_dependency: count ament_cmake_python as a build tool - #185
Conversation
ament_cmake packages install their own Python modules through ament_cmake_python, which they declare as a buildtool_depend. Those were not scanned, so e.g. rosidl_cmake, ament_cmake_test, angles, srdfdom and rosbag2_storage_mcap were built once, with their modules in the site-packages of the build-time Python only. Scan buildtool_depend/buildtool_export_depend for the known markers (not for any "python" name: a plain python3 build tool stays ignored), and add rosidl_pycommon to the markers (rosidl_generator_rs, ros_gz_bridge).
|
Thanks! |
|
One agent noted this:
This is totally true, but not introduced in this PR. |
ament_cmake packages install their own Python modules through ament_cmake_python, which they declare as a buildtool_depend. Those were not scanned, so e.g. rosidl_cmake, ament_cmake_test, angles, srdfdom and rosbag2_storage_mcap were built once, with their modules in the site-packages of the build-time Python only.
Scan buildtool_depend/buildtool_export_depend for the known markers (not for any "python" name: a plain python3 build tool stays ignored), and add rosidl_pycommon to the markers (rosidl_generator_rs, ros_gz_bridge).