Repository navigation
[Fix] Built-in integration tools stay unavailable after a failed read - #3630
Open
roomote-roomote[bot] wants to merge 1 commit into
Open
roomote-roomote[bot] wants to merge 1 commit into
roomote-roomote[bot] wants to merge 1 commit into
Conversation
Contributor
|
No code issues found. Reviewed retry/error transitions, cached-read recovery, integration-switch isolation, authentication guidance, and existing approval controls. Current-head lint, type checking, and Knip passed; tests, Docker build, and JavaScript/TypeScript CodeQL were still running when checked. See session Reviewed e00d049 |
roomote-roomote
Bot
requested review from
brunobergher,
daniel-lxs and
mrubens
as code owners
October 30, 2026 05:15
This was referenced Oct 30, 2026
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related issue
Scoped product recovery work; no linked issue.
Why this PR exists
What changed
A failed built-in tool catalog left Manage tools with only Close, even after connectivity returned. A compact Retry now refetches the existing query in place, retains the error/account-linking help while pending, prevents duplicate requests and scopes late completion to the integration. Success restores the ordinary catalog/approval controls.
Why this change was made
Recover a transient failure where it occurred using the existing custom-MCP pattern: one transient state record, no new API/dependency/persisted setting.
Impact
No close/reopen or page reload is needed. Initial loading, empty catalogs, read-only access and policy management retain their behavior; downstream policy recovery and server pagination remain separate.
How it was tested
c97173a7: actual keyless Exa catalog, controlled catalog transport abort, no Retry after removing the fault.e00d0490cdff51c1cd51aef6bafb0ac132e6cd48; same-head automated review clean, no unresolved threads.Screenshots
Controlled catalog failure, then real recovery after removing the interruption:
Related PRs
Checklist
[Fix],[Feat],[Improve],[Refactor],[Docs], or[Chore]followed by a user-facing descriptionpnpm lintandpnpm check-typespass locallypnpm changesetNormal fast static gates were used; formatting-inclusive full commands and a changeset were not run.