Repository navigation
[Fix] Starting a session goal fails without feedback - #3632
Open
roomote-roomote[bot] wants to merge 1 commit into
Open
roomote-roomote[bot] wants to merge 1 commit into
roomote-roomote[bot] wants to merge 1 commit into
Conversation
Contributor
|
No code issues found. See session Reviewed the goal-start error handling, draft preservation and retry behavior, handled server errors, and regression tests against the shared composer submission contract. Lint, Type Check, and Knip passed; tests, the app Docker build, and JavaScript/TypeScript CodeQL were still running at the time of review. Repository validation suites were left to CI. Reviewed 57d07b7 |
roomote-roomote
Bot
requested review from
brunobergher,
daniel-lxs and
mrubens
as code owners
October 30, 2026 05:41
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related issue
Scoped session composer recovery; no linked issue.
Why this PR exists
What changed
A rejected
/goalstart request could silently leave the goal text in the composer, making Submit appear ineffective. It now shows Could not start the goal. with the error detail or a short retry fallback. The draft remains available for retry; handled server errors, successful goals and ordinary replies retain their behavior.Why this change was made
The shared prompt input preserves rejected submissions but expects its caller to provide feedback. A small local catch closes the goal command's missing failure path using existing toasts, without changing generic input or backend behavior.
Impact
Immediate failure feedback with the same draft available for another attempt. No new state, setting, dependency, API or command syntax.
How it was tested
c97173a7: actual local demo session, transport abort offastSessions.startGoal, Submit leaves text but no error feedback./goalkeeps its existing validation, retains text and makes no goal request. Fault/drafts cleared; no actual goal job or external message started.57d07b7fcf22d3c196315279031db352d3649052; automated review clean, no unresolved threads.Screenshots
Actual Submit with controlled goal transport interruption:
Related PRs
Checklist
[Fix],[Feat],[Improve],[Refactor],[Docs], or[Chore]followed by a user-facing descriptionpnpm lintandpnpm check-typespass locallypnpm changesetNormal fast static gates were used; formatting-inclusive full commands and a changeset were not run.