Skip to content

[Fix] Starting a session goal fails without feedback - #3632

Open
roomote-roomote[bot] wants to merge 1 commit into
developfrom
fix/goal-start-error-feedback-3e6fs9l1l4lxa
Open

roomote-roomote[bot] wants to merge 1 commit into
developfrom
fix/goal-start-error-feedback-3e6fs9l1l4lxa

Conversation

@roomote-roomote

@roomote-roomote roomote-roomote Bot commented Oct 30, 2026 •

Copy link
Copy Markdown
Contributor

​Opened on behalf of @daniel-lxs. Follow up by mentioning @roomote-roomote, in the web UI, or in Telegram.

Related issue

Scoped session composer recovery; no linked issue.

Why this PR exists

  • A maintainer explicitly invited this PR in the linked issue or discussion
  • I am a maintainer / this is internal Roomote work

What changed

A rejected /goal start request could silently leave the goal text in the composer, making Submit appear ineffective. It now shows Could not start the goal. with the error detail or a short retry fallback. The draft remains available for retry; handled server errors, successful goals and ordinary replies retain their behavior.

Why this change was made

The shared prompt input preserves rejected submissions but expects its caller to provide feedback. A small local catch closes the goal command's missing failure path using existing toasts, without changing generic input or backend behavior.

Impact

Immediate failure feedback with the same draft available for another attempt. No new state, setting, dependency, API or command syntax.

How it was tested

  • Clean develop c97173a7: actual local demo session, transport abort of fastSessions.startGoal, Submit leaves text but no error feedback.
  • Same stimulus on the real changed app at 390×844 and 1440×1000 shows feedback and retains the full draft. Repeated Submit generates another failed request. At the exact committed head, mobile and desktop drafts remain after the standard toast expires and can be submitted again.
  • With interception removed, objective-free /goal keeps its existing validation, retains text and makes no goal request. Fault/drafts cleared; no actual goal job or external message started.
  • All 112 transcript client tests pass, including rejected-request detail/fallback, same-draft retry-to-success and handled-server-error cases. Web types and normal commit/pre-push gates pass. Hosted tests/build/CodeQL/static/backup/upgrade/Judgement pass/expected-skip at 57d07b7fcf22d3c196315279031db352d3649052; automated review clean, no unresolved threads.
  • Both final images opened/inspected and independently checked against identical source. Mobile toast temporarily overlays the composer: full draft/retry behavior is established by actual value/interaction checks and tests, not the still alone. Disclosed controlled transport failure, no fabricated response/DOM or live provider/goal-execution claim. Dark/all-viewport parity not claimed; unrelated existing test warnings unchanged. Documentation evaluated: syntax/usage unchanged.

Screenshots

Actual Submit with controlled goal transport interruption:

Mobile goal-start failure feedback
Desktop goal-start failure and retained draft

Related PRs

Checklist

  • The PR title follows the repo convention: [Fix], [Feat], [Improve], [Refactor], [Docs], or [Chore] followed by a user-facing description
  • This PR is small and scoped to one change
  • pnpm lint and pnpm check-types pass locally
  • I added tests or included a clear manual validation note above
  • I removed secrets, tokens, private keys, and customer data from code, logs, and screenshots
  • If this change should appear in the changelog, I ran pnpm changeset

Normal fast static gates were used; formatting-inclusive full commands and a changeset were not run.

@roomote-community

roomote-community Bot commented Oct 30, 2026 •

Copy link
Copy Markdown
Contributor

No code issues found. See session

Reviewed the goal-start error handling, draft preservation and retry behavior, handled server errors, and regression tests against the shared composer submission contract. Lint, Type Check, and Knip passed; tests, the app Docker build, and JavaScript/TypeScript CodeQL were still running at the time of review. Repository validation suites were left to CI.

Reviewed 57d07b7

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant