Repository navigation
fix: keep Skip setup from applying a placement once Automation access is allowed - #789
Conversation
… is allowed A placement waiting for Automation access survived Skip setup. An access check that setup started when StableBar became active could then come back allowed after setup closed, apply the discarded placement and hide the macOS menu bar after the restore. Skip setup now drops the waiting placement too, so a late check has nothing to apply. Fixes #788
Before and after
203 unchanged screens
Visual review: 203 screens, none changed. |
) completedActionCannotRestartAReplacedWidget holds a widget action until the test has reloaded the configuration and seen the replacement widget's output. The widget set no timeout, so the action got the default 10 seconds, and on CI the main-actor turns in between took longer: the command was killed and store.actionErrors kept the timeout (PR #789's run took 75 seconds). The widget now sets a 120-second timeout, as #656 gave the other held commands in this file. A probe that held the main actor for 11 seconds after the action started failed the test the same way before this change and passed after it. Fixes #790
…tate machine Main now drops a placement waiting for Automation access when setup is skipped (Seb-GRAF#789). Skipping only bumped the request counter here, so a check that came back allowed after setup closed still applied it. Skipping now moves to its own phase, where every late answer is dropped.
Problem
When setup's placement was waiting for Automation access, Skip setup could still apply it: an access check that setup starts each time StableBar becomes active could come back allowed after setup closed, then hide the macOS menu bar after the restore. Fixes #788.
Changes
SetupSession.cancel()now clearsplacementAwaitingAccessas well as bumpingplacementRequest. The check inrefreshAccess()applies only the placement still waiting, so a late answer finds none and does nothing. A placement already on its way throughplace(_:)was dropped by the request counter before, and still is.Testing
skippingSetupWhileAccessIsCheckedAgainLeavesTheMenuBarAlone: a placement refused access,refreshAccess()with its check held open, Skip setup, then the check answers allowed. Before the fix it failed (the menu bar was hidden), and now it passes.swift build --build-tests, then the full suite: 1235 Swift Testing tests and 299 XCTest tests pass.scripts/check.sh --quickand commitlint pass.Merging
Any method: one
fix:commit. #787 moves this logic intoSetupPlacementand keeps today's behavior. Whichever lands second needs.skippedto leave the waiting placement there too.Claude Opus 5.5 via Claude Code