Skip to content

feat(pens): rework the pen editor window (#111) - #164

Merged
mrcsin merged 37 commits into
masterfrom
pen-editor-redesign
Nov 9, 2026
Merged

mrcsin merged 37 commits into
masterfrom
pen-editor-redesign

Conversation

@mrcsin

@mrcsin mrcsin commented Nov 9, 2026 •

Copy link
Copy Markdown
Member

Problem

The pen editor's table showed read-only checkboxes that looked editable (#111), and editing a pen meant tabbing between a grid and separate pages.

What changed

  • The window is three panes: a sortable, filterable pen list, the selected pen's form, and a groups pane that sets the pen's membership and renames or deletes groups.
  • The list shows the start flag as a check glyph, not a control. Every column opens no narrower than its header and resizes; one column takes the spare width.
  • The filter matches number, name or group, in any case, and never selects a row on its own.
  • The colour field takes # and six hex digits and leaves a stored value as stored until it is edited.
  • Four plans move to docs/plans/completed/: hex-color-input, pen-editor-pens-pane, pen-editor-groups-pane, pen-list-filter.

Verification

  • SemiPlot.Tests.Unit passes on the branch; each plan lists its acceptance tests and a "Verify it yourself" section.
  • dotnet format --verify-no-changes and dotnet terse clean.
  • Manual check on the live demo passed.

Closes #111

Per-task commits before squash
cc2f919 docs(plans): archive the pen editor plans
931841c docs(plans): record the pen list filter exec run
d95f050 refactor(pen-editor): address smells review
bdb0ba3 fix(pen-editor): address review findings
1fa3c66 docs(pen-editor): document the pen list filter
cc5b0a0 docs(plans): record the pen list filter checks
76dbce2 feat(pen-editor): add the pen list's filter box
e8099aa feat(pen-editor): filter the pen list's view
4fc8159 feat(pen-editor): add the pen list's match rule
538a79d docs(plans): record the groups pane exec run
d2809c0 refactor(pen-editor): address smells review
1644e28 fix(pen-editor): address review findings
919d2c6 docs(pen-editor): document the groups pane
f674b99 docs(plans): record the acceptance check
44135df feat(pen-editor): open at the screen's width
06606ec feat(pen-editor): stand the three panes under a top bar
a76ed4a feat(pen-editor): replace the groups tab with the groups pane
3b62018 feat(theme): add the destructive button style
8ecbe9a docs(plans): record the pens pane exec run
291ceec refactor(pen-editor): address smells review
e3aa23c fix(pen-editor): address review findings
745f7ca docs(architecture): describe the pen list and pane
ae037fe docs(plans): record the pens pane acceptance run
34443a8 feat(pen-editor): show the pen form in a sectioned pane
04c922f feat(pen-editor): show the pens in a sortable DataGrid
e7e3317 refactor(pen-editor): add the pen list sort orders
a56991d feat(tables): size grid columns from their headers
4062325 build(ui): add the DataGrid and its palette keys
06f1e46 docs(plans): record the hex colour exec run
d53b144 refactor(input): drop restating summaries
4c300ae refactor(input): address smells review
d9a5bdd fix(input): address review findings
86833af docs(input): describe the hex colour field layout
b5e723a test(input): verify the hex colour acceptance
acc4f8c feat(pen-editor): normalise the colour box to hex
cfb766d feat(input): add the HexColor field layout
9885d61 refactor(input): move the time field input to Input

🤖 Generated with Claude Code

mrcsin and others added 30 commits November 3, 2026 11:05
The smells review found the pen editor view tests at 1584 lines, literals
repeated between AXAML and code, and a per-layout LINQ scan in the column
fit. Split the view tests by concern, give each repeated value one home,
and fold the fill-column lookup into one loop. Behaviour is unchanged.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@mrcsin
mrcsin merged commit ed39fac into master Nov 9, 2026
2 checks passed
@mrcsin
mrcsin deleted the pen-editor-redesign branch November 9, 2026 15:33
mrcsin added a commit that referenced this pull request Nov 10, 2026
All seven slices merged in #164 to #167; the roadmap records each
slice's plan, pull request and branch.

Co-authored-by: Oleg <18466855+EvaTheSalmon@users.noreply.github.com>
Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Pen editor: read-only boxes in the pen table look editable

1 participant