Repository navigation
feat(pens): rework the pen editor window (#111) - #164
Merged
Merged
Conversation
The smells review found the pen editor view tests at 1584 lines, literals repeated between AXAML and code, and a per-layout LINQ scan in the column fit. Split the view tests by concern, give each repeated value one home, and fold the fill-column lookup into one loop. Behaviour is unchanged. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
The pen editor's table showed read-only checkboxes that looked editable (#111), and editing a pen meant tabbing between a grid and separate pages.
What changed
#and six hex digits and leaves a stored value as stored until it is edited.docs/plans/completed/: hex-color-input, pen-editor-pens-pane, pen-editor-groups-pane, pen-list-filter.Verification
SemiPlot.Tests.Unitpasses on the branch; each plan lists its acceptance tests and a "Verify it yourself" section.dotnet format --verify-no-changesanddotnet terseclean.Closes #111
Per-task commits before squash
🤖 Generated with Claude Code