Repository navigation
Run mod callbacks on KSA 2026.11.10.5801 - #115
Closed
Maximilian-Nesslauer wants to merge 1 commit into
Closed
Maximilian-Nesslauer wants to merge 1 commit into
Maximilian-Nesslauer wants to merge 1 commit into
Conversation
- Call the StarMapAllModsLoaded methods without arguments, because ModLibrary.LoadAll has an optional parameter now - Hook StarMapImmediateLoad to Mod.LoadSettings when Mod.PrepareSystems is gone, and skip the callback with a warning when KSA has neither - Add the using for the NativeList extension that moved to Brutal.Collections
github-actions
Bot
changed the base branch from
main
to
feature/external/pr-115-fix-5801-mod-loading
November 8, 2026 13:43
Contributor
Author
|
Closing this in favor of #114, which makes the same three changes and also makes the missing-target case safe in One difference to keep in mind: this PR hooked |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #113.
KSA 2026.11.10.5801 changed two things that StarMap hooks into, so on that build mods do not get their
[StarMapAllModsLoaded]and[StarMapImmediateLoad]callbacks.ModLibrary.LoadAllhas an optional parameter now. The[StarMapAllModsLoaded]callbacks have no parameters, so they are called without arguments.Mod.PrepareSystemsis gone.[StarMapImmediateLoad]hooksMod.PrepareSystemswhen KSA has it andMod.LoadSettingsotherwise, whichModLibrary.PrepareAllcalls for each mod at the old place. When KSA has neither, StarMap writes a warning and skips the callback, and the loader goes on.ConfirmRestartneedsusing Brutal.Collections;, because thePtrextension ofNativeListmoved there.I built it against the 5801 assemblies and ran a mod with all four callbacks (
[StarMapBeforeMain],[StarMapImmediateLoad],[StarMapAllModsLoaded],[StarMapUnload]) plus three mods that set up in[StarMapAllModsLoaded]: each callback ran, once.The exception at shutdown when the game starts with
-InstancePathis a different problem and not part of this change.