Repository navigation
GH#101: respect browser motion preferences and filter control reveal - #121
Draft
superdav42 wants to merge 4 commits into
Draft
superdav42 wants to merge 4 commits into
superdav42 wants to merge 4 commits into
Conversation
Collaborator
Author
Implementation Checkpoint
aidevops.sh v3.39.27 plugin for OpenCode v1.19.0 with gpt-6.1-sol spent 9m and 149,287 tokens on this as a headless worker. |
|
Important Draft PR not reviewedDraft PRs are not automatically reviewed by default.
To automatically review draft PRs, update your CodeRabbit configuration: reviews:
auto_review:
drafts: true
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Resolves #101. Updated to follow the requested browser/filter policy rather than adding an admin option.
prefers-reduced-motion: reducefor every button theme.sce_skip_control_reveal(default boolean, comment ID). Its default is true when WP ULike is active, detected byWP_ULIKE_VERSION, so SCE does not add a decorative fade beside ULike's buttons. Plugins can return true or false; false never overrides the browser's reduced-motion preference.Files and patterns
simple-comment-editing.php: existing wrapper-class/filter pattern, with the documented per-comment reveal filter.src/scss/frontend.scss: hidden/pending controls and theme-independent reduced-motion overrides.src/js/comment-editing/editing.js: affirmativecan_editrequirement and fail-closed permission errors, preserving repeat-safe initialization.dist/sce-editing.js,dist/sce-frontend.css,dist/sce-frontend.css.map: rebuilt using the existing webpack command.README.md,readme.txt,DESIGN.md: filter contract, browser precedence, caching/authorization limits and motion policy.includes/Options.phpandincludes/Admin/Tabs/Settings.phpnow match master; the proposed setting has been removed entirely.Verification
Implementation head:
9e250eb(plus the resolved master merge8f4ed54).Passed locally:
PHPCS: no errors, four existing direct-database warnings in unchanged cleanup queries. Scoped PHPStan: no errors. ESLint: no errors, six existing warnings. Webpack succeeds with the existing admin-bundle size/performance warnings; unrelated admin-bundle regeneration drift was discarded.
The existing focused PHPUnit command was attempted but exits before running:
Set WP_TEST_DB_NAME to a disposable database ending in _test.The development site's database was not used for PHPUnit. Current-head CI remains required; old-head green checks are not evidence for this update.Real-browser verification
Tested the actual built PR worktree on the configured WordPress site with Twenty Twenty-Five, using separate named Chromium sessions for the guest owner, subscriber and non-owner. The shared plugin symlink was switched with operator permission; stale local PHP bootstrap caching was resolved by an operator-authorized graceful PHP reload.
showContainer, duration0.6s.none.sce-reduced-motion, computed animationnone.showContainer; reduced-motion browser still usesnone.none. Temporary filter consumer removed afterward.can_edit: false.visibility: hidden, with the request error in the status region.Separate compatibility finding: WP ULike's like button disappears after guest inline Save until reload. Saved text persists, and reload restores the button. Tracked independently in #123; do not treat this as a complete ULike integration sign-off. Its response/formatting sources are unchanged by this PR.
Temporary fixture post/comments/user and integration policies are removed after testing; ULike is restored to inactive. The site and authorized PR worktree symlink remain available for follow-up. No release, merge, or live deployment is included.
aidevops.sh v3.39.36 plugin for OpenCode