Skip to content

Prefer exact assertions in tests - #3258

Merged
adamtheturtle merged 1 commit into
mainfrom
prefer-exact-test-assertions
Sep 21, 2026
Merged

Prefer exact assertions in tests#3258
adamtheturtle merged 1 commit into
mainfrom
prefer-exact-test-assertions

Conversation

@adamtheturtle

@adamtheturtle adamtheturtle commented Sep 21, 2026

Copy link
Copy Markdown
Member

Summary

  • compare complete target lists before and after deletion
  • cover both synchronous and asynchronous clients

Tests

  • uv run --group dev pytest -q tests/test_vws.py::TestDelete::test_delete_target tests/test_async_vws.py::TestDelete::test_delete_target
  • PREK_CONCURRENT_BATCHES=1 uv run --group dev prek run --files tests/test_vws.py tests/test_async_vws.py

@adamtheturtle
adamtheturtle merged commit 2d6aaf9 into main Sep 21, 2026
13 checks passed
@adamtheturtle
adamtheturtle deleted the prefer-exact-test-assertions branch September 21, 2026 11:56

This branch was successfully deployed

1 active deployment
development — 34a112e3 Deployed Sep 21, 2026 by adamtheturtle via pages #1104
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@adamtheturtle