Skip to content

Prefer exact assertions in tests #3258

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
adamtheturtle merged 1 commit into from
Sep 21, 2026
Merged

Prefer exact assertions in tests #3258

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions tests/test_async_vws.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -207,12 +207,12 @@ async def test_delete_target(
target_id=target_id,
)
targets = await async_vws_client.list_targets()
assert target_id in targets
assert targets == [target_id]
await async_vws_client.delete_target(
target_id=target_id,
)
targets = await async_vws_client.list_targets()
assert target_id not in targets
assert targets == []


class TestGetTargetSummaryReport:
Expand Down
4 changes: 2 additions & 2 deletions tests/test_vws.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -365,9 +365,9 @@ def test_delete_target(
)

vws_client.wait_for_target_processed(target_id=target_id)
assert target_id in vws_client.list_targets()
assert vws_client.list_targets() == [target_id]
vws_client.delete_target(target_id=target_id)
assert target_id not in vws_client.list_targets()
assert vws_client.list_targets() == []


class TestGetTargetSummaryReport:
Expand Down
Loading