Repository navigation
Fail at startup on unknown element types in <content> - #95
Merged
alexanderoster merged 1 commit intoOct 27, 2026
Merged
Conversation
An element inside <content> that is neither a content item nor a registered module type (for example a misspelled item name) was skipped silently. The server started normally and the client later failed with an obscure JS error after login, with nothing pointing at config.xml. CUIModule_Content now throws INVALIDMODULETYPE with the element name. Non-element children (comments, text, processing instructions) are skipped by node type rather than by an empty name, since a processing instruction has a name. The separate isSupportedModuleType check is dropped because moduleTypeIsRegistered already includes it.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
An element inside that is neither a content item nor a registered module type (for example a misspelled item name) was skipped silently. The server started normally and the client later failed with an obscure JS error after login, with nothing pointing at config.xml.
CUIModule_Content now throws INVALIDMODULETYPE with the element name. Non-element children (comments, text, processing instructions) are skipped by node type rather than by an empty name, since a processing instruction has a name. The separate isSupportedModuleType check is dropped because moduleTypeIsRegistered already includes it.